[ate]: Remove client singleton and support multiple instances#241
Merged
moidx merged 1 commit intolowRISC:mainfrom Jun 24, 2025
Merged
[ate]: Remove client singleton and support multiple instances#241moidx merged 1 commit intolowRISC:mainfrom
moidx merged 1 commit intolowRISC:mainfrom
Conversation
This commit refactors the ATE client library to remove the singleton pattern to enable downstream users to manage multiple client instances. Previously, `CreateClient` would always return the same client instance, making it impossible to connect to multiple, distinct provisioning servers from a single application. The singleton implementation also had a potential race condition in the `CreateClient` call. This change introduces the following: - The `ate_dll.cc` no longer uses a static client. Each call to `CreateClient` now returns a new, independent client instance. - Callers are now responsible for managing the lifecycle of each client and must call `DestroyClient` for every instance created. - The documentation in `ate_api.h` and `ate.md` has been updated to reflect the new factory pattern, and a guide has been added for managing multiple client instances. Signed-off-by: Miguel Osorio <miguelosorio@google.com>
timothytrippel
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the ATE client library to remove the singleton pattern to enable downstream users to manage multiple client instances.
Previously,
CreateClientwould always return the same client instance, making it impossible to connect to multiple, distinct provisioning servers from a single application. The singleton implementation also had a potential race condition in theCreateClientcall.This change introduces the following:
ate_dll.ccno longer uses a static client. Each call toCreateClientnow returns a new, independent client instance.DestroyClientfor every instance created.ate_api.handate.mdhas been updated to reflect the new factory pattern, and a guide has been added for managing multiple client instances.