[pa/spm] Improve SPM and PA error handling and logging #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothytrippel
approved these changes
Jun 27, 2025
This commit introduces several improvements to error handling and logging in the SPM and PA services. In the Provisioning Appliance (PA): - Replaced generic internal error statuses with the specific status codes returned by the SPM. This provides more meaningful error information to the client. - Enhanced log messages to include the SKU, which aids in debugging and tracing requests for specific device types. In the Secure Provisioning Module (SPM): - Corrected gRPC status codes to more accurately reflect the nature of the error. For example, using `NotFound` for unknown SKUs and `Unauthenticated` for failed authentication instead of `Internal`. - Made error messages more descriptive by including contextual information such as the SKU, which helps in diagnosing issues. - Changed several `Internal` errors to `InvalidArgument` where the failure is due to invalid data from the client, such as during certificate validation. - Added more details to cryptographic-related error messages to assist in debugging signature and parsing failures. Signed-off-by: Miguel Osorio <[email protected]>
moidx
force-pushed
the
pa-spm-error-reporting-improvements
branch
from
660720e to
ac37702
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces several improvements to error handling and logging in the SPM and PA services.
In the Provisioning Appliance (PA):
In the Secure Provisioning Module (SPM):
NotFoundfor unknown SKUs andUnauthenticatedfor failed authentication instead ofInternal.Internalerrors toInvalidArgumentwhere the failure is due to invalid data from the client, such as during certificate validation.