Skip to content

Commit 6fb13be

Browse files
committed
[kmac, rtl/dv/sw] Remove unused error code
The `ErrShadowRegUpdate` code is never used in the RTL. Instead, according to the documentation, on a shadow register update error, a recoverable alert shall be triggered - this recoverable alert then is signaled in the STATUS register and not in the error code register. Hence, this commit removes this error code as well as the corresponding SW code (`kDifErrorShadowRegisterUpdate`). Signed-off-by: Pascal Nasahl <[email protected]>
1 parent b8596ff commit 6fb13be

File tree

4 files changed

+1
-8
lines changed

4 files changed

+1
-8
lines changed

hw/ip/kmac/dv/env/kmac_env_cov.sv

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -301,8 +301,7 @@ class kmac_env_cov extends cip_base_env_cov #(.CFG_T(kmac_env_cfg));
301301
kmac_err_code: coverpoint kmac_err {
302302
ignore_bins ignore = {kmac_pkg::ErrNone};
303303
// Covered by direct sequence, if scb enabled for those seq, can remove it from this list.
304-
illegal_bins il = {kmac_pkg::ErrShadowRegUpdate,
305-
kmac_pkg::ErrWaitTimerExpired,
304+
illegal_bins il = {kmac_pkg::ErrWaitTimerExpired,
306305
kmac_pkg::ErrIncorrectEntropyMode,
307306
kmac_pkg::ErrSwHashingWithoutEntropyReady};
308307
}

hw/ip/kmac/rtl/kmac_pkg.sv

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -456,9 +456,6 @@ package kmac_pkg;
456456
// - Sw issues KMAC op without Entropy setting.
457457
ErrSwHashingWithoutEntropyReady = 8'h 09,
458458

459-
// Error Shadow register update
460-
ErrShadowRegUpdate = 8'h C0,
461-
462459
// Error due to lc_escalation_en_i or fatal fault
463460
ErrFatalError = 8'h C1,
464461

sw/device/lib/dif/dif_kmac.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -402,8 +402,6 @@ typedef enum dif_kmac_error {
402402

403403
kDifErrorSoftwareHashingWithoutEntropyReady = 9,
404404

405-
kDifErrorShadowRegisterUpdate = 0xC0,
406-
407405
kDifErrorFatalError = 0xC1,
408406

409407
kDifErrorPackerIntegrity = 0xC2,

sw/device/lib/dif/dif_kmac_unittest.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -792,7 +792,6 @@ class KmacGetErrorTest : public KmacTest {
792792
kDifErrorIncorrectFunctionName,
793793
kDifErrorSoftwareCommandSequence,
794794
kDifErrorSoftwareHashingWithoutEntropyReady,
795-
kDifErrorShadowRegisterUpdate,
796795
kDifErrorFatalError,
797796
kDifErrorPackerIntegrity,
798797
kDifErrorMsgFifoIntegrity,

0 commit comments

Comments
 (0)