[crypto] Let otcrypto_aes() have up to 3 blocks in flight #24722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the hot loop inside otcrypto_aes() would only ever have 2 blocks in flight while the underlying driver function aes_update() as well as the hardware allows up to 3 blocks being in flight: - Block x-1 can be retrieved from the data output registers by SW. - Block x is being processed by HW. - Block x+1 can already be provided via the data input registers by SW. Doing this is better for SCA hardening (more concurrency means more background noise) and allows achieving higher throughput. This is related to lowRISC#20308. This is a cherry pick of commit 8f0f500 to branch earlgrey_es_sival. Signed-off-by: Pirmin Vogel <[email protected]>
vogelpi
requested review from
HU90m and
jadephilipoom
and removed request for
a team
jadephilipoom
approved these changes
Oct 3, 2024
|
Thanks for your approval @jadephilipoom . CI passes except for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the hot loop inside otcrypto_aes() would only ever have 2 blocks in flight while the underlying driver function aes_update() as well as the hardware allows up to 3 blocks being in flight:
Doing this is better for SCA hardening (more concurrency means more background noise) and allows achieving higher throughput.
This is related to #20308.
This is a cherry pick of commit 8f0f500 to branch earlgrey_es_sival.