Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rom_ext] Elimiate RSA app firmware validation #24726

Merged
merged 2 commits into from
Oct 4, 2024
Merged

[rom_ext] Elimiate RSA app firmware validation #24726

merged 2 commits into from
Oct 4, 2024

Conversation

cfrantz
Copy link
Contributor

@cfrantz cfrantz commented Oct 3, 2024 •
edited
Loading

  1. Remove RSA verification from rom_ext_verify.
  2. Remove RSA keys from the test_owner configuration.
  3. Remove RSA key material from the repo.

Addresses: #24641

@cfrantz cfrantz marked this pull request as ready for review October 3, 2024 21:36
@cfrantz cfrantz requested a review from a team as a code owner October 3, 2024 21:36
@cfrantz cfrantz removed the request for review from a team October 3, 2024 21:36
@cfrantz
[rom_ext] Elimiate RSA app firmware validation
56c0739 
1. Remove RSA verification from rom_ext_verify.
2. Remove RSA keys from the test_owner configuration.

Addresses: lowRISC#24641

Signed-off-by: Chris Frantz <[email protected]>
@cfrantz
[rom_ext] Eliminate ROM_EXT RSA application keys
e3ff47d 
Addresses: lowRISC#24641

Signed-off-by: Chris Frantz <[email protected]>
@cfrantz
Copy link
Contributor Author

cfrantz commented Oct 4, 2024

The following tests (which failed in CI) pass locally:

  • //sw/device/silicon_creator/rom_ext/e2e/ownership:flash_permission_test_fpga_hyper310_rom_ext
  • //sw/device/tests:i2c_target_test_fpga_cw310_sival
  • //sw/device/tests:sysrst_ctrl_in_irq_test_fpga_cw310_sival
  • //sw/device/tests:sysrst_ctrl_inputs_test_fpga_cw310_sival

@cfrantz cfrantz merged commit 38c253c into lowRISC:earlgrey_es_sival Oct 4, 2024
22 of 25 checks passed
@moidx moidx mentioned this pull request Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothytrippel timothytrippel timothytrippel approved these changes

@moidx moidx Awaiting requested review from moidx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cfrantz @timothytrippel