[multitop] New bazel rules to describe HW

BUILD.bazel

@@ -14,8 +14,10 @@ filegroup(
     name = "cores",
     srcs = [
         "check_tool_requirements.core",
+        "tool_requirements.py",
         "topgen.core",
         "topgen-reg-only.core",
+        "//util:check_tool_requirements.py",
     ],
 )
 

hw/BUILD

@@ -35,7 +35,7 @@ string_list_flag(
 fusesoc_build(
     name = "verilator_real",
     srcs = [
-        ":all_files",
+        "//hw/top",
     ],
     cores = [
         "//:cores",
@@ -101,25 +101,6 @@ genrule(
     visibility = ["//visibility:public"],
 )
 
-# TODO(lowRISC/opentitan#7972): Globbing all of the //hw/... hierarchy together
-# is a bit of a hack.  Longer term, we need proper rules for expressing the
-# relationships between verilog components.
-filegroup(
-    name = "all_files",
-    srcs = glob(
-        ["**"],
-        # TODO(lowRISC/opentitan#15882): make Verilator work with foundry repo present.
-        exclude = ["foundry/**"],
-    ) + [
-        "//:tool_requirements.py",
-        "//hw/ip:all_files",
-        "//hw/ip_templates:all_files",
-        "//hw/top_earlgrey:all_files",
-        "//util:check_tool_requirements.py",
-    ],
-    visibility = ["//visibility:public"],
-)
-
 pkg_files(
     name = "package",
     srcs = ["verilator_bin"],

hw/bitstream/vivado/BUILD

@@ -40,7 +40,7 @@ fusesoc_build(
     name = "fpga_cw310",
     testonly = True,
     srcs = [
-        "//hw:all_files",
+        "//hw/top",
         _CW310_TESTROM,
         _OTP_RMA,
     ],
@@ -90,7 +90,7 @@ fusesoc_build(
     name = "fpga_cw310_hyperdebug",
     testonly = True,
     srcs = [
-        "//hw:all_files",
+        "//hw/top",
         _CW310_TESTROM,
         _OTP_RMA,
     ],
@@ -140,7 +140,7 @@ fusesoc_build(
     name = "fpga_cw340",
     testonly = True,
     srcs = [
-        "//hw:all_files",
+        "//hw/top",
         _CW340_TESTROM,
         _OTP_RMA,
     ],

hw/ip_templates/clkmgr/BUILD → hw/dv/BUILD

@@ -6,5 +6,7 @@ package(default_visibility = ["//visibility:public"])
 
 filegroup(
     name = "all_files",
-    srcs = glob(["**"]),
+    srcs = glob(
+        ["**"],
+    ),
 )

hw/ip/BUILD

@@ -3,41 +3,3 @@
 # SPDX-License-Identifier: Apache-2.0
 
 package(default_visibility = ["//visibility:public"])
-
-filegroup(
-    name = "all_files",
-    srcs = glob(["**"]) + [
-        "//hw/ip/adc_ctrl:all_files",
-        "//hw/ip/aes:all_files",
-        "//hw/ip/aon_timer:all_files",
-        "//hw/ip/csrng:all_files",
-        "//hw/ip/edn:all_files",
-        "//hw/ip/entropy_src:all_files",
-        "//hw/ip/gpio:all_files",
-        "//hw/ip/hmac:all_files",
-        "//hw/ip/i2c:all_files",
-        "//hw/ip/keymgr:all_files",
-        "//hw/ip/kmac:all_files",
-        "//hw/ip/lc_ctrl:all_files",
-        "//hw/ip/otbn:all_files",
-        "//hw/ip/otp_ctrl:all_files",
-        "//hw/ip/pattgen:all_files",
-        "//hw/ip/prim:all_files",
-        "//hw/ip/prim_generic:all_files",
-        "//hw/ip/prim_xilinx:all_files",
-        "//hw/ip/prim_xilinx_ultrascale:all_files",
-        "//hw/ip/pwm:all_files",
-        "//hw/ip/rom_ctrl:all_files",
-        "//hw/ip/rv_core_ibex:all_files",
-        "//hw/ip/rv_dm:all_files",
-        "//hw/ip/rv_timer:all_files",
-        "//hw/ip/spi_device:all_files",
-        "//hw/ip/spi_host:all_files",
-        "//hw/ip/sram_ctrl:all_files",
-        "//hw/ip/sysrst_ctrl:all_files",
-        "//hw/ip/tlul:all_files",
-        "//hw/ip/trial1:all_files",
-        "//hw/ip/uart:all_files",
-        "//hw/ip/usbdev:all_files",
-    ],
-)

hw/ip/adc_ctrl/BUILD

@@ -2,11 +2,12 @@
 # Licensed under the Apache License, Version 2.0, see LICENSE for details.
 # SPDX-License-Identifier: Apache-2.0
 
+load("//rules/opentitan:hw.bzl", "opentitan_ip")
+
 package(default_visibility = ["//visibility:public"])
 
-filegroup(
-    name = "all_files",
-    srcs = glob(["**"]) + [
-        "//hw/ip/adc_ctrl/data:all_files",
-    ],
+opentitan_ip(
+    name = "adc_ctrl",
+    files = glob(["**"]),
+    hjson = "//hw/ip/adc_ctrl/data:hjson",
 )

hw/ip/adc_ctrl/data/BUILD

@@ -4,27 +4,7 @@
 
 package(default_visibility = ["//visibility:public"])
 
-load(
-    "//rules:autogen.bzl",
-    "autogen_hjson_c_header",
-    "autogen_hjson_rust_header",
-)
-
-autogen_hjson_c_header(
-    name = "adc_ctrl_c_regs",
-    srcs = [
-        "adc_ctrl.hjson",
-    ],
-)
-
-autogen_hjson_rust_header(
-    name = "adc_ctrl_rust_regs",
-    srcs = [
-        "adc_ctrl.hjson",
-    ],
-)
-
 filegroup(
-    name = "all_files",
-    srcs = glob(["**"]),
+    name = "hjson",
+    srcs = ["adc_ctrl.hjson"],
 )

hw/ip/aes/BUILD

@@ -2,13 +2,14 @@
 # Licensed under the Apache License, Version 2.0, see LICENSE for details.
 # SPDX-License-Identifier: Apache-2.0
 
+load("//rules/opentitan:hw.bzl", "opentitan_ip")
+
 package(default_visibility = ["//visibility:public"])
 
-filegroup(
-    name = "all_files",
-    srcs = glob(["**"]) + [
-        "//hw/ip/aes/data:all_files",
-    ],
+opentitan_ip(
+    name = "aes",
+    files = glob(["**"]),
+    hjson = "//hw/ip/aes/data:hjson",
 )
 
 cc_library(

hw/ip/aes/data/BUILD

@@ -4,27 +4,7 @@
 
 package(default_visibility = ["//visibility:public"])
 
-load(
-    "//rules:autogen.bzl",
-    "autogen_hjson_c_header",
-    "autogen_hjson_rust_header",
-)
-
-autogen_hjson_c_header(
-    name = "aes_c_regs",
-    srcs = [
-        "aes.hjson",
-    ],
-)
-
-autogen_hjson_rust_header(
-    name = "aes_rust_regs",
-    srcs = [
-        "aes.hjson",
-    ],
-)
-
 filegroup(
-    name = "all_files",
-    srcs = glob(["**"]),
+    name = "hjson",
+    srcs = ["aes.hjson"],
 )

hw/ip/aon_timer/BUILD

@@ -2,11 +2,12 @@
 # Licensed under the Apache License, Version 2.0, see LICENSE for details.
 # SPDX-License-Identifier: Apache-2.0
 
+load("//rules/opentitan:hw.bzl", "opentitan_ip")
+
 package(default_visibility = ["//visibility:public"])
 
-filegroup(
-    name = "all_files",
-    srcs = glob(["**"]) + [
-        "//hw/ip/aon_timer/data:all_files",
-    ],
+opentitan_ip(
+    name = "aon_timer",
+    files = glob(["**"]),
+    hjson = "//hw/ip/aon_timer/data:hjson",
 )

hw/ip/aon_timer/data/BUILD

@@ -4,27 +4,7 @@
 
 package(default_visibility = ["//visibility:public"])
 
-load(
-    "//rules:autogen.bzl",
-    "autogen_hjson_c_header",
-    "autogen_hjson_rust_header",
-)
-
-autogen_hjson_c_header(
-    name = "aon_timer_c_regs",
-    srcs = [
-        "aon_timer.hjson",
-    ],
-)
-
-autogen_hjson_rust_header(
-    name = "aon_timer_rust_regs",
-    srcs = [
-        "aon_timer.hjson",
-    ],
-)
-
 filegroup(
-    name = "all_files",
-    srcs = glob(["**"]),
+    name = "hjson",
+    srcs = ["aon_timer.hjson"],
 )

hw/ip/csrng/BUILD

@@ -2,11 +2,12 @@
 # Licensed under the Apache License, Version 2.0, see LICENSE for details.
 # SPDX-License-Identifier: Apache-2.0
 
+load("//rules/opentitan:hw.bzl", "opentitan_ip")
+
 package(default_visibility = ["//visibility:public"])
 
-filegroup(
-    name = "all_files",
-    srcs = glob(["**"]) + [
-        "//hw/ip/csrng/data:all_files",
-    ],
+opentitan_ip(
+    name = "csrng",
+    files = glob(["**"]),
+    hjson = "//hw/ip/csrng/data:hjson",
 )

hw/ip/csrng/data/BUILD

@@ -4,27 +4,7 @@
 
 package(default_visibility = ["//visibility:public"])
 
-load(
-    "//rules:autogen.bzl",
-    "autogen_hjson_c_header",
-    "autogen_hjson_rust_header",
-)
-
-autogen_hjson_c_header(
-    name = "csrng_c_regs",
-    srcs = [
-        "csrng.hjson",
-    ],
-)
-
-autogen_hjson_rust_header(
-    name = "csrng_rust_regs",
-    srcs = [
-        "csrng.hjson",
-    ],
-)
-
 filegroup(
-    name = "all_files",
-    srcs = glob(["**"]),
+    name = "hjson",
+    srcs = ["csrng.hjson"],
 )

hw/ip/edn/BUILD

@@ -2,11 +2,12 @@
 # Licensed under the Apache License, Version 2.0, see LICENSE for details.
 # SPDX-License-Identifier: Apache-2.0
 
+load("//rules/opentitan:hw.bzl", "opentitan_ip")
+
 package(default_visibility = ["//visibility:public"])
 
-filegroup(
-    name = "all_files",
-    srcs = glob(["**"]) + [
-        "//hw/ip/edn/data:all_files",
-    ],
+opentitan_ip(
+    name = "edn",
+    files = glob(["**"]),
+    hjson = "//hw/ip/edn/data:hjson",
 )

hw/ip/edn/data/BUILD

@@ -4,27 +4,7 @@
 
 package(default_visibility = ["//visibility:public"])
 
-load(
-    "//rules:autogen.bzl",
-    "autogen_hjson_c_header",
-    "autogen_hjson_rust_header",
-)
-
-autogen_hjson_c_header(
-    name = "edn_c_regs",
-    srcs = [
-        "edn.hjson",
-    ],
-)
-
-autogen_hjson_rust_header(
-    name = "edn_rust_regs",
-    srcs = [
-        "edn.hjson",
-    ],
-)
-
 filegroup(
-    name = "all_files",
-    srcs = glob(["**"]),
+    name = "hjson",
+    srcs = ["edn.hjson"],
 )

hw/ip/entropy_src/BUILD

@@ -2,11 +2,12 @@
 # Licensed under the Apache License, Version 2.0, see LICENSE for details.
 # SPDX-License-Identifier: Apache-2.0
 
+load("//rules/opentitan:hw.bzl", "opentitan_ip")
+
 package(default_visibility = ["//visibility:public"])
 
-filegroup(
-    name = "all_files",
-    srcs = glob(["**"]) + [
-        "//hw/ip/entropy_src/data:all_files",
-    ],
+opentitan_ip(
+    name = "entropy_src",
+    files = glob(["**"]),
+    hjson = "//hw/ip/entropy_src/data:hjson",
 )