[dice] Refactor some dice related constants and APIs #25023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommychiu-github
requested review from
pamaury
and removed request for
a team
|
@timothytrippel for viz. |
tommychiu-github
force-pushed
the
main
branch
from
e6ba2ed
to
3567df4
Compare
It'll be invoked by several modules, so move it to base:util library for code reuse. Signed-off-by: Tommy Chiu <[email protected]>
Both X509 and CWT DICE implementations need these definitions. Move it out from the original source file for code reuse. Signed-off-by: Tommy Chiu <[email protected]>
The autogen source from templates needs some more APIs to utilize the Cbor structure, including - calculate the size of a given cbor argument - add a bstr/tstr header with size, and rewind the cursor - copy the war data from input pointer to the CborOut buffer Signed-off-by: Tommy Chiu <[email protected]>
tommychiu-github
force-pushed
the
main
branch
from
3567df4
to
6c60a5c
Compare
| return kErrorOk; \ | ||
| } while (0) | ||
|
|
||
| inline rom_error_t cbor_write_out_init(struct CborOut *p, void *buf, |
There was a problem hiding this comment.
I think you want to keep all of these inline functions in the header file and mark then static inline. You can still share them with everything that include the header. It ensure they get inlined without LTO: https://stackoverflow.com/a/47821267 (applies to all inline functions)
| CborWriteBstr(data_size, data, p); | ||
| CBOR_CHECK_OVERFLOWED_AND_RETURN(p); | ||
| } | ||
| rom_error_t cbor_write_out_init(struct CborOut *p, void *buf, |
There was a problem hiding this comment.
all functions prototypes in the header file should have doxygen style comments: https://cs.opensource.google/opentitan/opentitan/+/master:sw/device/lib/testing/i2c_testutils.h;l=158
| CborWriteBstr(data_size, data, p); | ||
| CBOR_CHECK_OVERFLOWED_AND_RETURN(p); | ||
| } | ||
| rom_error_t cbor_write_out_init(struct CborOut *p, void *buf, |
There was a problem hiding this comment.
Suggested change
| rom_error_t cbor_write_out_init(struct CborOut *p, void *buf, | |
| OT_WARN_UNUSED | |
| rom_error_t cbor_write_out_init(struct CborOut *p, void *buf, |
?
Comment on lines
+134
to
+135
| "//sw/device/silicon_creator/lib/cert:dice_keys", | ||
| "//sw/device/silicon_creator/manuf/lib:flash_info_fields", |
There was a problem hiding this comment.
why are these two deps needed here?
| kUtilEcdsaP256SignatureComponentBytes = | ||
| kUtilEcdsaP256SignatureComponentBits / 8, | ||
| /** | ||
| * Size of an attestation signature component in 32b words. |
There was a problem hiding this comment.
Suggested change
| * Size of an attestation signature component in 32b words. | |
| * Size of an ECDSA signature component in 32b words. |
| */ | ||
| kUtilEcdsaP256SignatureComponentBits = 256, | ||
| /** | ||
| * Size of an attestation signature component in bytes. |
There was a problem hiding this comment.
Suggested change
| * Size of an attestation signature component in bytes. | |
| * Size of an ECDSA signature component in bytes. |
| @@ -12,6 +12,23 @@ | |||
| extern "C" { | |||
| #endif | |||
|
|
|||
| enum { | |||
| /** | |||
| * Size of an attestation signature component in bits. | |||
There was a problem hiding this comment.
Suggested change
| * Size of an attestation signature component in bits. | |
| * Size of an ECDSA signature component in bits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some DICE key creation constants and utilities are invoked by several modules.
Refactor them for a better code reuse.