[kmac,sival] Enable KMAC error conditions test to partially run on CW310 #25180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexJones0
requested review from
alees24,
nasahlpa,
engdoreis and
vogelpi
and removed request for
a team and
alees24
AlexJones0
added
the
CherryPick:earlgrey_1.0.0
nasahlpa
approved these changes
Nov 18, 2024
engdoreis
approved these changes
Nov 18, 2024
AlexJones0
changed the title
This commit enables the KMAC error conditions test in the CW310 FPGA execution environment, conditionally disabling the first three tests when running in this environment - the CW310 lacks the masking features for these tests to run, but there is still value in running the remaining 7 tests in a CW310 environment. CI prioritisation now also prioritises CW340 over CW310, meaning that the full set of tests will still be running in CI as usual - this just helps provide more thorough testing. Signed-off-by: Alex Jones <[email protected]>
AlexJones0
force-pushed
the
kmac_error_test_cw310
branch
from
84a0466 to
6718155
Compare
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the
kmac_error_conditions_test(added in #24765) in the CW310 FPGA execution environment, conditionally disabling the first three tests when running in this environment.As mentioned in the code and in that PR, the CW310 lacks the masking features for these tests to run, but there is still value in running the remaining 7 tests in a CW310 environment. CI prioritisation now also prioritises CW340 over CW310 (#24947), meaning that the full set of tests will still be running in CI as usual.
This has been tested to run on a CW310 locally for 10 iterations:
./bazelisk.sh test -t- --test_output=streamed --runs_per_test=10 //sw/device/tests:kmac_error_conditions_test_fpga_cw310_sival@nasahlpa