Skip to content

[ci] Remove old dependencies from apt-requirements.txt #27605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025

Conversation

jwnrt
Copy link
Contributor

@jwnrt jwnrt commented Jul 10, 2025

I believe all of these are things that are now handled within Bazel so we don't need to download them on the system anymore.

@jwnrt jwnrt force-pushed the strip-apt-requirements branch 2 times, most recently from 77709d8 to 58f1998 Compare July 14, 2025 11:38
@jwnrt jwnrt marked this pull request as ready for review July 14, 2025 12:48
@jwnrt jwnrt requested a review from rswarbrick as a code owner July 14, 2025 12:48
@jwnrt jwnrt requested a review from nbdd0121 July 14, 2025 12:48
Copy link
Contributor

@rswarbrick rswarbrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming everything works (which has presumably just been checked in CI), this looks like a really excellent change.

@nbdd0121
Copy link
Contributor

Assuming everything works (which has presumably just been checked in CI), this looks like a really excellent change.

Our CI containers use an earlier OT snapshot to pre-install some packages. So this isn't really a good indication apart the jobs that run on GitHub-hosted runners only.

Copy link
Contributor

@nbdd0121 nbdd0121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the removed packages, could you try to test in CI by explicitly apt remove them?

@jwnrt jwnrt force-pushed the strip-apt-requirements branch from a75d04e to df0c6c3 Compare July 15, 2025 13:00
@hcallahan-lowrisc
Copy link
Contributor

One minor nit, probably also worth removing packages from the markdown list in doc/getting_started/unofficial/fedora.md too.

I believe all of these are things that are now handled within Bazel so
we don't need to download them on the system anymore.

Signed-off-by: James Wainwright <[email protected]>
@jwnrt jwnrt force-pushed the strip-apt-requirements branch from df0c6c3 to dc16ce6 Compare July 15, 2025 14:25
@jwnrt
Copy link
Contributor Author

jwnrt commented Jul 15, 2025

CI passes with explicitly removing those packages (with an autoremove as well) so I think this is safe

@jwnrt jwnrt force-pushed the strip-apt-requirements branch from dc16ce6 to 376fab4 Compare July 15, 2025 15:36
Copy link
Contributor

@nbdd0121 nbdd0121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for testing out. This is the run: https://github.com/lowRISC/opentitan/actions/runs/16296028670

@jwnrt jwnrt merged commit b7cdf57 into lowRISC:master Jul 16, 2025
45 checks passed
@jwnrt jwnrt deleted the strip-apt-requirements branch July 16, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants