[crypto] AES-GCM FI Hardening #27633
Draft
+68
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nasahlpa
added
the
CherryPick:earlgrey_1.0.0
This commit adds additional hardening against FI to AES-GCM. When setting the key security_level > low, the AES operation performed by the AES IP block is checked by recomputing the input. Signed-off-by: Pascal Nasahl <[email protected]>
Replace kOtcryptoKeySecurityLevelLow with kOtcryptoKeySecurityLevelHigh to make sure that the AES-GCM FI protection is tested as well. Not testing security_level low is fine as low is a subset of high. Signed-off-by: Pascal Nasahl <[email protected]>
By setting kOtcryptoKeySecurityLevelHigh, the CL will use countermeasures to protect the AES-GCM computation against FI. Enable this protection for the CL AES-GCM pentesting. Signed-off-by: Pascal Nasahl <[email protected]>
nasahlpa
force-pushed
the
aes_gcm_fi_hardening
branch
from
2d183ad to
6809f47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional hardening against FI to AES-GCM. When setting the key security_level > low, the AES operation performed by the AES IP block is checked by recomputing the input.