Cherry-pick to master: [sw,keymgr] trap if keymgr is idle after starting op #28129 #28477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `keymgr_wait_until_done()` function should be only called after an operation has been started by the caller. This commit removes the `IDLE` status check from the switch-case in `keymgr_wait_until_done()` to enforce this invariant. If the keymgr is found to be `IDLE` the execution will now proceed to the default error-handling case and trigger a trap. Change-Id: I35b5107174796e9a52eff7ab33bdc2260453a73b Signed-off-by: Yi-Hsuan Deng <[email protected]> (cherry picked from commit abac206)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is manual cherrypick of:
Original commit message:
The
keymgr_wait_until_done()function should be only called after an operation has been started by the caller.This commit removes the
IDLEstatus check from the switch-case inkeymgr_wait_until_done()to enforce this invariant. If the keymgr is found to beIDLEthe execution will now proceed to the default error-handling case and trigger a trap.