Skip to content

Conversation

nasahlpa
Copy link
Member

This commit adds AES-GCM to the cryptotest framework. The test vectors are the nist_cavp_aes_gcm with 128, 192, 256 encrypt and decrypt.

As the cryptolib only supports tag sizes of 4,8,12,16 and iv sizes of 12, 16 bytes, other test vectors are filtered. Also, for performance reasons, only AAD, CTX, PTX sizes of 64 bytes and less are tested.

@nasahlpa nasahlpa added the CherryPick:earlgrey_1.0.0 This PR should be cherry-picked to earlgrey_1.0.0 label Oct 15, 2025
@nasahlpa
Copy link
Member Author

All 7200 tests pass on my CW340 with the current CL version.

@nasahlpa nasahlpa marked this pull request as ready for review October 15, 2025 09:20
@nasahlpa nasahlpa requested review from a team and cfrantz as code owners October 15, 2025 09:20
@nasahlpa nasahlpa requested review from engdoreis and timothytrippel and removed request for a team and timothytrippel October 15, 2025 09:20
This commit adds AES-GCM to the cryptotest framework. The test vectors
are the nist_cavp_aes_gcm with 128, 192, 256 encrypt and decrypt.

As the cryptolib only supports tag sizes of 4,8,12,16 and iv sizes of
12, 16 bytes, other test vectors are filtered. Also, for performance
reasons, only AAD, CTX, PTX sizes of 64 bytes and less are tested.

Signed-off-by: Pascal Nasahl <[email protected]>
Copy link
Contributor

@johannheyszl johannheyszl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nasahlpa this is a great addition and good to hear the tests are passing!

@nasahlpa nasahlpa requested a review from andreaskurth October 15, 2025 17:22
Copy link
Contributor

@siemen11 siemen11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for including the GCM NIST vectors Pascal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CherryPick:earlgrey_1.0.0 This PR should be cherry-picked to earlgrey_1.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants