Skip to content

Conversation

sasdf
Copy link
Contributor

@sasdf sasdf commented Oct 15, 2025

This PR refactors UartConsole by extracting complex functionalities into dedicated plugin middleware modules, simplifying its core logic.

sasdf added 4 commits October 16, 2025 12:01
Change-Id: Ic985163aae1df4e375c95a87e9bdd2b8cda5304f
Signed-off-by: Yi-Hsuan Deng <[email protected]>
Change-Id: I3525ee97aaed424c877702a4fa9a8bff954ceac3
Signed-off-by: Yi-Hsuan Deng <[email protected]>
Change-Id: I0a0e8639753c90e5f5a0ab00de9aa14663dec715
Signed-off-by: Yi-Hsuan Deng <[email protected]>
Change-Id: Idfdbdbb35414946e8f60a6395fb9dc235fe29845
Signed-off-by: Yi-Hsuan Deng <[email protected]>
sasdf added 2 commits October 16, 2025 15:20
Change-Id: Ie3bde3b09906b5b9c8eb6b9229d98cf4f37ba76c
Signed-off-by: Yi-Hsuan Deng <[email protected]>
Change-Id: I4f82f73e24a20672f6ef173d0ee230c0989b80d4
Signed-off-by: Yi-Hsuan Deng <[email protected]>
@nbdd0121
Copy link
Contributor

Instead of plugins, I would like to get rid of UartConsole completely. It currently has a few features today:

  • Interacting through stdin -- this is only used by opentitantool console, and should just be implemented there instead.
  • Waiting for status -- this should just be an utility function that takes dyn Uart and performs the wait
  • Printing to the log -- this should be a middleware that also implements Uart which is just a wrapper, it passes data through and internally performs line-buffering; when a whole line is received it gets printed.

Coverage would also, in my opinion, just be a middleware that implements Uart and passes everything through apart from poll_read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants