[dv,top_earlgrey] Add some top earlgrey env features for use in future tests #28491
+53
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcallahan-lowrisc
requested review from
KinzaQamar,
phani-lowrisc and
rswarbrick
…ary. Signed-off-by: Harry Callahan <[email protected]>
Signed-off-by: Harry Callahan <[email protected]>
This task can be forked into the background to capture UART console traffic into the test logs. This is useful for observation and sequencing inside logfiles. Signed-off-by: Harry Callahan <[email protected]>
Signed-off-by: Harry Callahan <[email protected]>
This is in support of future tests which will invoke the bootstrapping routine multiple times within a single simulation. Signed-off-by: Harry Callahan <[email protected]>
hcallahan-lowrisc
force-pushed
the
top_earlgrey_env_features
branch
from
d245fb0 to
d244459
Compare
|
I've just started reading through the commits one-by-one (and have only read the first one so far). I think I'm convinced that it's right, but it might make sense to expand the commit message to make it clear that the only code that consumes a |
rswarbrick
reviewed
Oct 16, 2025
| cfg.mem_bkdr_util_h[FlashBank1Info].set_mem(); | ||
| // Backdoor load the OTP image. | ||
| cfg.mem_bkdr_util_h[Otp].load_mem_from_file(cfg.otp_images[cfg.use_otp_image]); | ||
| if (cfg.use_otp_image != OtpNone) begin |
There was a problem hiding this comment.
What a horrible variable name! I keep thinking it's a boolean :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review commit-by-commit, these additions are all currently unused and should not affect existing tests.