Cherry-pick to master: [rom_ext] Deref symlinks in imm_section release tarball #28495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![lowrisc-ci[bot]](https://avatars.githubusercontent.com/in/923580?s=80&v=4){kind=small}
The `gen_stamped_tarball.py` script is used to create a release tarball for the imm_section rom_ext. By default, `tarfile.open()` does not dereference symbolic links, which means the tarball would contain broken symlinks if the imm_section rom_ext are symlinks. This change adds `dereference=True` to `tarfile.open()` to ensure that symbolic links are followed and their target files are added to the tarball instead of the symlinks themselves. Change-Id: I17b2456b36e8efd411276b0702d2e430563e2d58 Signed-off-by: Yi-Hsuan Deng <[email protected]> (cherry picked from commit 7ed7ea0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic cherry-pick of #28464 to branch
master.