[rescue] Update rescue GPIO param to unblock CI #28500
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonychen1251
force-pushed
the
fix-spi-dfu-rescue-disability-test
branch
from
1fda5a0 to
19b53da
Compare
The spidfu_rescue_boot_svc_req_disability test was introduced in lowRISC#28385 and was passing its checks. However, a concurrent change in lowRISC#28440 renamed the RESCUE_GPIO parameter to WITH_RESCUE_GPIO_PARAM. This renaming was not propagated to the test owner config for the spidfu_rescue_boot_svc_req_disability, causing CI to keep failing on spidfu_rescue_boot_svc_req_disability test and blocking the check. This updates the parameter name to WITH_RESCUE_GPIO_PARAM in the configuration to resolve the CI failures. Signed-off-by: Anthony Chen <[email protected]>
anthonychen1251
force-pushed
the
fix-spi-dfu-rescue-disability-test
branch
from
19b53da to
ea84caa
Compare
|
Rebased. |
cfrantz
approved these changes
Oct 17, 2025
|
The two failing tests (rescue_firmware_slot_b_usbdfu_fpga_hyper310_rom_ext and usbdfu_out_chunk_too_big_fpga_hyper310_rom_ext) both pass locally. It appears CI lost the USB device. Retrying CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
spidfu_rescue_boot_svc_req_disabilitytest was introduced in #28385 and was passing its checks. However, a concurrent change in #28440 renamed the RESCUE_GPIO parameter to WITH_RESCUE_GPIO_PARAM.This renaming was not propagated to the spidfu_rescue_boot_svc_req_disability owner config, causing CI to keep failing on
spidfu_rescue_boot_svc_req_disabilitytest and blocking the check.This updates the parameter name to WITH_RESCUE_GPIO_PARAM in the configuration to resolve the CI failures.