[opentitanlib] move dif/top specific abstractions to ot_hal
#28508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbdd0121
commented
Oct 17, 2025
There was a problem hiding this comment.
hardened bools are not moved to ot_hal as they're a concept only in ROM/ROM_EXT and is not related to IP/top.
This is the new place for hardware abstractions. Signed-off-by: Gary Guo <[email protected]>
nbdd0121
force-pushed
the
ot_hal
branch
2 times, most recently
from
bef2346 to
038f43a
Compare
Signed-off-by: Gary Guo <[email protected]>
pamaury
reviewed
Oct 18, 2025
|
|
||
| # Hack to make bindgen generate less for English Breakfast. | ||
| new = REPO_TOP / 'sw/host/opentitanlib/bindgen/BUILD' | ||
| new = REPO_TOP / 'sw/host/ot_hal/bindgen/BUILD' |
There was a problem hiding this comment.
Note: I believe that the prepare_sw.py script is already broken, we have not been able to make it work over the MT transition. There is a PR to make verilator work again without this #28012 But I guess it doesn't really hurt to change it.
pamaury
approved these changes
Oct 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is yet another PR in attempt to modularize and break down
opentitanlib.DIF/top-specific logic is quite independent from anything else, this makes it a good candidate to modularize.