[otlib] Move target reset configuration from CLI to files #28509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexJones0
approved these changes
Oct 17, 2025
The RX clearing mechanism is implemented (in a slightly different improved way) in `target_reset` so it's okay to defer that to `reset_target(true)`. Signed-off-by: James Wainwright <[email protected]>
This allows us to have one function using a default configured reset and another one that allows specifying the reset. Signed-off-by: James Wainwright <[email protected]>
Signed-off-by: James Wainwright <[email protected]>
Reset delays are now configured once in configuration files and cannot be changed per-test on the command line. This commit switches all uses of the `reset_target` function to use either `reset` or `reset_with_delay` where appropriate. All delays should be exactly the same after this commit. Signed-off-by: James Wainwright <[email protected]>
jwnrt
force-pushed
the
earlgrey-1.0.0-reset-delay
branch
from
2b318ea to
fda4184
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we never use the
--reset-delayCLI flag. We think it makes more sense to configure the reset delay for a whole target at once rather than each test; for example QEMU needs a longer reset delay than FPGAs or silicon.This PR splits the
reset_targetfunction into two:resetwhich uses the configured delayreset_with_delaywhich accepts a custom delayThis PR should be a no-op on all of our tests. The observable change is that there is no longer a
--reset-delayflag but there is areset_delayconfig field.