[hw,pwrmgr,rtl] Correct the rom integrity bypass on rom_done signal

[Razer6]

The pwrmgr supports to bypass the rom integrity checks when in RMA or TEST_UNLOCKED (lc_dft_en_i, lc_hw_debug_en_i are asserted). Then it should bypass the check on the rom done and rom good signal. While for the good signal, this check is properly implemented, the done signal seems to have an issue:

assign rom_intg_chk_done = mubi4_or_hi(mubi4_and_hi(rom_intg_chk_dis, rom_ctrl_done_i),
                                       rom_ctrl_done_i);

The bypass via rom_intg_chk_dis is only honored if rom_ctrl_done_i is asserted. If so, I don't need a bypass. Thus, this boils down to:

assign rom_intg_chk_done = rom_ctrl_done_i;

With no bypass at all.

This PR fixes that by doing a simple OR between the bypass and the actual done signal, the same way it is done for the good signal.

[a-will]

Are there any risks to releasing the pwrmgr FSM faster? I note that until rom_ctrl is done with the check, the rom_ctrl's internal FSM keeps control of the bus, effectively preventing execution by the CPU.

[Razer6]

I was thinking about the same and you are probably right. Running through the FSM without waiting is maybe also not the right thing to do.