[crypto] Check if byte-copy was successful #28773
Open
+24
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nasahlpa
added
the
CherryPick:earlgrey_1.0.0
After a byte-wise copy using randomized_bytecopy() use the function consttime_memeq_byte() to check if copying the data was successful. This is a FI mitigation. Closes lowRISC#28753. Signed-off-by: Pascal Nasahl <[email protected]>
nasahlpa
force-pushed
the
bytecopy_check
branch
from
1250168 to
c023447
Compare
siemen11
approved these changes
Nov 19, 2025
To reduce SCA leakage, randomize the order we are reading from the two buffers. This is in-line with other functions in `hardened_memory`. Signed-off-by: Pascal Nasahl <[email protected]>
Member
Author
Thanks Hakim - yes this is a good point. I've pushed another commit that does the randomization of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a byte-wise copy using randomized_bytecopy() use the function consttime_memeq_byte() to check if copying the data was successful. This is a FI mitigation.
Closes #28753.