Cherry-pick to earlgrey_1.0.0: Remove legacy splice #25924 #28784
+4
−309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amaury Pouly <[email protected]> (cherry picked from commit 828d65d)
The legacy splice rules (//hw:splice.bzl) has been deprecated: users must specify the otp image using the `otp` attribute of the `fpga_params` macro. Also remove splice targets in //hw/bitstream which had no users. Signed-off-by: Amaury Pouly <[email protected]> (cherry picked from commit 2984301)
Signed-off-by: Amaury Pouly <[email protected]> (cherry picked from commit 1753848)
sasdf
changed the title
Contributor
|
I did a similar change on master: #25924 It's possible that |
Contributor
Author
|
I have updated the PR to cherry pick your commits. It only has a minor conflict on the bitstream package, and CI looks fine. |
pamaury
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
fpga_paramssupports specifying OTP images directly, the previousbitstream_splicetargets that were used to combine a ROM bitstream with an OTP image are no longer needed.This change removes them to centralize bitstream specification in the exec_env configuration.