add min/max methods

lrnv · Nov 17, 2023 · ce8f8fd · ce8f8fd · lrnv · Nov 17, 2023
1 parent 2d6d091
commit ce8f8fd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "WilliamsonTransforms"
 uuid = "48feb556-9bdd-43a2-8e10-96100ec25e22"
 authors = ["Oskar Laverny <[email protected]> and contributors"]
-version = "0.1.0"
+version = "0.1.1"
 
 [deps]
 Distributions = "31c24e10-a181-5473-b8eb-7969acd0382f"

diff --git a/src/WilliamsonTransforms.jl b/src/WilliamsonTransforms.jl
@@ -10,6 +10,7 @@ import Distributions
 import TaylorSeries
 import Base.minimum
 import Roots
+import Base: minimum, maximum
 
 export 𝒲, 𝒲₋₁
 
@@ -110,12 +111,14 @@ function Distributions.cdf(d::𝒲₋₁, x::Real)
     # return 1-rez
 end
 function Distributions.logpdf(d::𝒲₋₁, x::Real)
-    ϕ_d = taylor(d.ϕ, x, d.d+1, typeof(x))[end]
+    ϕ_d = max(taylor(d.ϕ, x, d.d+1, typeof(x))[end],0)
     r = (d.d-1)*log(x) - sum(log.(1:(d.d-1)))
     return log(ϕ_d) + r
 end
 function Distributions.rand(rng::Distributions.AbstractRNG, d::𝒲₋₁)
     u = rand(rng)
     Roots.find_zero(x -> (Distributions.cdf(d,x) - u), (0.0, Inf))
 end
+Base.minimum(::𝒲₋₁) = 0.0
+Base.maximum(::𝒲₋₁) = Inf
 end