`Lectures`: Fix attachment lecture units creation #11115

florian-glombik · 2025-07-07T11:42:06Z

Checklist

General

I tested all changes and their related features with all corresponding user types on a test server.
I chose a title conforming to the naming conventions for pull requests.

Client

I strictly followed the client coding and design guidelines.
I added an E2E test
I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

The Add attachment as lecture unit button does not work on develop since #10575; this will be fixed by this PR.

While fixing it, I've noticed that the route definition can be simplified by using constants for the authorities.

Description

Exchange redundant authorities definition with constants
Fix route definition (and thereby the Add attachment as lecture unit button)
Remove the Attachments status section from the edit lecture page, which was forgotten when the section itself was removed in Lectures: Prefer attachment units over attachments #10708

Steps for Testing

Create a lecture (or use an existing one)
Edit the Attachments of the lecture
Verify the Add attachment as lecture unit button forwards you to a new page

Testserver States

You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.

Review Progress

Performance Review

Code Review

Code Review 1
Code Review 2

Manual Tests

Test 1
Test 2

Test Coverage

Addded an E2E test

Screenshots

Attachment units forwarding works again

Before fix

Removed Attachments section from status bar

Before fix

Attachments section does not exist anymore on that page, will always be invalid

Summary by CodeRabbit

New Features
- Added hierarchical role groups for access control, simplifying permissions across course and lecture management sections.
- Improved navigation for adding lecture attachments by updating button links and identifiers.
Bug Fixes
- Streamlined visibility of lecture management links by consolidating permission checks and adding unique identifiers for easier access.
Tests
- Introduced new automated tests to verify the process of opening the attachment unit creation page in lecture management.
- Enhanced test utilities to support navigation and interaction with lecture attachments.

github-actions · 2025-07-07T12:26:31Z

End-to-End (E2E) Test Results Summary

	Tests	Passed ☑️	Skipped ⚠️	Failed ❌️	Time ⏱
End-to-End (E2E) Test Report	201 ran	195 passed	3 skipped	3 failed	58m 56s 470ms

Test	Result	Time ⏱
End-to-End (E2E) Test Report
e2e/exercise/quiz-exercise/QuizExerciseManagement.spec.ts
ts.Quiz Exercise Management › Quiz Exercise Creation › Creates a Quiz with Drag and Drop	❌ failure	2m 3s 523ms
e2e/exercise/programming/ProgrammingExerciseParticipation.spec.ts
ts.Programming exercise participation › Programming exercise team participation › Team members make git submissions	❌ failure	47s 100ms
e2e/exercise/programming/ProgrammingExerciseStaticCodeAnalysis.spec.ts
ts.Static code analysis tests › Configures SCA grading and makes a successful submission with SCA errors	❌ failure	2m 13s 755ms

src/main/webapp/app/lecture/manage/lecture-attachments/lecture-attachments.component.html

github-actions · 2025-07-07T13:14:51Z

End-to-End (E2E) Test Results Summary

	Tests	Passed ✅	Skipped	Failed	Time ⏱
End-to-End (E2E) Test Report	1 ran	1 passed	0 skipped	0 failed	1s 689ms

Test	Result	Time ⏱
No test annotations available

github-actions · 2025-07-08T00:14:06Z

End-to-End (E2E) Test Results Summary

	Tests	Passed ☑️	Skipped ⚠️	Failed ❌️	Time ⏱
End-to-End (E2E) Test Report	202 ran	197 passed	3 skipped	2 failed	54m 14s 691ms

Test	Result	Time ⏱
End-to-End (E2E) Test Report
e2e/exercise/quiz-exercise/QuizExerciseManagement.spec.ts
ts.Quiz Exercise Management › Quiz Exercise Creation › Creates a Quiz with Drag and Drop	❌ failure	2m 3s 760ms
e2e/exercise/programming/ProgrammingExerciseParticipation.spec.ts
ts.Programming exercise participation › Programming exercise team participation › Team members make git submissions	❌ failure	39s 264ms

ahmetsenturk

code

cemsinan-tum · 2025-07-08T13:07:15Z

Tested on artemis-test2 via instructor account 15, it works as intended.

github-actions · 2025-07-08T13:51:23Z

End-to-End (E2E) Test Results Summary

	Tests	Passed ☑️	Skipped ⚠️	Failed ❌️	Time ⏱
End-to-End (E2E) Test Report	202 ran	196 passed	3 skipped	3 failed	57m 17s 331ms

Test	Result	Time ⏱
End-to-End (E2E) Test Report
e2e/exercise/quiz-exercise/QuizExerciseParticipation.spec.ts
ts.Quiz Exercise Participation › DnD Quiz participation › Student can participate in DnD Quiz	❌ failure	2m 3s 214ms
e2e/exercise/programming/ProgrammingExerciseParticipation.spec.ts
ts.Programming exercise participation › Programming exercise team participation › Team members make git submissions	❌ failure	42s 428ms
e2e/exercise/programming/ProgrammingExerciseStaticCodeAnalysis.spec.ts
ts.Static code analysis tests › Configures SCA grading and makes a successful submission with SCA errors	❌ failure	2m 8s 788ms

tobias-lippert

code

src/main/webapp/app/lecture/manage/lecture-update/lecture-update.component.spec.ts

jonas-de

works as expected on TS2, code changes look good

github-actions · 2025-07-09T11:54:41Z

End-to-End (E2E) Test Results Summary

	Tests	Passed ☑️	Skipped ⚠️	Failed ❌️	Time ⏱
End-to-End (E2E) Test Report	202 ran	197 passed	3 skipped	2 failed	56m 37s 845ms

Test	Result	Time ⏱
End-to-End (E2E) Test Report
e2e/exercise/programming/ProgrammingExerciseParticipation.spec.ts
ts.Programming exercise participation › Programming exercise team participation › Team members make git submissions	❌ failure	45s 46ms
e2e/exercise/programming/ProgrammingExerciseStaticCodeAnalysis.spec.ts
ts.Static code analysis tests › Configures SCA grading and makes a successful submission with SCA errors	❌ failure	2m 12s 874ms

badkeyy

(Rereview) Code

chuuuun

worked expected on ts6 : )

konrad2002

tested on TS2, works as expected

florian-glombik added 6 commits July 4, 2025 12:04

Simplify authorities for routes

a7e0b18

Simplify route definition

900188c

Make injections readonly

ac31d01

Simplify route authority definition

49d1d02

Fix javadoc

9d2df97

Remove attachments section from status bar

f680a3b

github-project-automation bot added this to Artemis Development Jul 7, 2025

github-project-automation bot moved this to Work In Progress in Artemis Development Jul 7, 2025

github-actions bot assigned florian-glombik Jul 7, 2025

github-actions bot added client Pull requests that update TypeScript code. (Added Automatically!) core Pull requests that affect the corresponding module iris Pull requests that affect the corresponding module lecture Pull requests that affect the corresponding module labels Jul 7, 2025

Fix attachment units button

9b9bb8f

florian-glombik commented Jul 7, 2025

View reviewed changes

src/main/webapp/app/lecture/manage/lecture-attachments/lecture-attachments.component.html Show resolved Hide resolved

coderabbitai bot previously approved these changes Jul 7, 2025

View reviewed changes

florian-glombik changed the title ~~Lectures: Fix attachment units~~ Lectures: Fix attachment lecture units creation Jul 7, 2025

florian-glombik added 2 commits July 7, 2025 14:58

Remove redundant check

800f910

Add 2e2 test

959dffb

florian-glombik dismissed coderabbitai[bot]’s stale review via 959dffb July 7, 2025 13:10

github-actions bot added tests playwright labels Jul 7, 2025

Merge branch 'develop' into bugfix/lecture/fix-attachment-units

e4f14d7

florian-glombik marked this pull request as ready for review July 7, 2025 13:14

florian-glombik requested review from a team and krusche as code owners July 7, 2025 13:14

github-actions bot removed the iris Pull requests that affect the corresponding module label Jul 7, 2025

github-actions bot added the ready for review label Jul 7, 2025

florian-glombik dismissed stale reviews from krusche, nils-jansen, timn21, and coderabbitai[bot] via 5866d48 July 7, 2025 23:24

coderabbitai bot approved these changes Jul 7, 2025

View reviewed changes

Merge branch 'develop' into bugfix/lecture/fix-attachment-units

a0bb24d

helios-aet bot temporarily deployed to artemis-test4.artemis.cit.tum.de July 8, 2025 01:00 Inactive

ahmetsenturk approved these changes Jul 8, 2025

View reviewed changes

helios-aet bot temporarily deployed to artemis-test2.artemis.cit.tum.de July 8, 2025 12:58 Inactive

cemsinan-tum closed this Jul 8, 2025

cemsinan-tum reopened this Jul 8, 2025

github-project-automation bot moved this from Ready For Review to Work In Progress in Artemis Development Jul 8, 2025

tobias-lippert approved these changes Jul 8, 2025

View reviewed changes

src/main/webapp/app/lecture/manage/lecture-update/lecture-update.component.spec.ts Show resolved Hide resolved

helios-aet bot temporarily deployed to artemis-test2.artemis.cit.tum.de July 9, 2025 08:05 Inactive

jonas-de approved these changes Jul 9, 2025

View reviewed changes

florian-glombik moved this from Work In Progress to Developer Approved in Artemis Development Jul 9, 2025

Merge branch 'develop' into bugfix/lecture/fix-attachment-units

504dd83

badkeyy approved these changes Jul 9, 2025

View reviewed changes

helios-aet bot temporarily deployed to artemis-test6.artemis.cit.tum.de July 9, 2025 18:21 Inactive

chuuuun approved these changes Jul 9, 2025

View reviewed changes

florian-glombik added the ready to merge label Jul 9, 2025

konrad2002 approved these changes Jul 10, 2025

View reviewed changes

krusche approved these changes Jul 10, 2025

View reviewed changes

krusche merged commit 3826642 into develop Jul 10, 2025
33 of 38 checks passed

krusche deleted the bugfix/lecture/fix-attachment-units branch July 10, 2025 16:47

github-project-automation bot moved this from Developer Approved to Merged in Artemis Development Jul 10, 2025

Lectures: Fix attachment lecture units creation #11115

Lectures: Fix attachment lecture units creation #11115

Uh oh!

Conversation

florian-glombik commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

General

Client

Motivation and Context

Description

Steps for Testing

Testserver States

Review Progress

Performance Review

Code Review

Manual Tests

Test Coverage

Screenshots

Attachment units forwarding works again

Before fix

Removed Attachments section from status bar

Before fix

Summary by CodeRabbit

Summary by CodeRabbit

Uh oh!

github-actions bot commented Jul 7, 2025

End-to-End (E2E) Test Results Summary

Uh oh!

Uh oh!

github-actions bot commented Jul 7, 2025

End-to-End (E2E) Test Results Summary

Uh oh!

github-actions bot commented Jul 8, 2025

End-to-End (E2E) Test Results Summary

Uh oh!

ahmetsenturk left a comment

Choose a reason for hiding this comment

Uh oh!

cemsinan-tum commented Jul 8, 2025

Uh oh!

github-actions bot commented Jul 8, 2025

End-to-End (E2E) Test Results Summary

Uh oh!

tobias-lippert left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jonas-de left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 9, 2025

End-to-End (E2E) Test Results Summary

Uh oh!

badkeyy left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chuuuun left a comment

Choose a reason for hiding this comment

Uh oh!

konrad2002 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

`Lectures`: Fix attachment lecture units creation #11115

`Lectures`: Fix attachment lecture units creation #11115

florian-glombik commented Jul 7, 2025 •

edited

Loading

jonas-de left a comment •

edited

Loading

badkeyy left a comment •

edited

Loading