Development: Add exercise id to result table to speed up database queries

[tobias-lippert]

Only deploy to TS1

Checklist

General

• I tested all changes and their related features with all corresponding user types on a test server.
• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Server

• Important: I implemented the changes with a very good performance and prevented too many (unnecessary) and too complex database calls.
• I strictly followed the principle of data economy for all database calls.
• I strictly followed the server coding and design guidelines.
• I documented the Java code using JavaDoc style.

Motivation and Context

We have some database calls that are extremely slow because six tables need to be joined

Description

We resolve this by denormalizing the schema and adding the exercise id to the result table.

• Added the liquibase changelog including backfill
• Adapted the code such that the exercise id is set when a new result is created
• Added the exercise id column to the result table
• Adapted test setup where necessary

Steps for Testing

Prerequisites:

• 1 Course with exercises with asssessments and (processed) complaints
• 1 assessed exam with processed complaints

1. Make sure the prerequisites are fulfilled, data can be created on any branch
2. Deploy develop or any other branch that doesn't affect assessment stats to TS4
3. Go to your desired course in course management
4. On the overview page, note down all the values written in the doughnut charts
5. Then go to assessment and note down all the values of assessments/complaints in the assessment dashboard
6. Then go to the exam assessment dashboard and note down the same as in 5.
7. Deploy this branch
8. Repeat steps 4-6 but this time check that the values match with those you've written down

Exam Mode Testing

Covered with the steps above

Testserver States

You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.

Review Progress

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

Performance Tests

• Test 1

Test Coverage

unchanged

Summary by CodeRabbit

• Bug Fixes

  • Complaint/more-feedback counts and assessment counts on dashboards and leaderboards are now accurate by consistently linking results to their exercises.

• New Features

  • Bulk/counting APIs now support computing complaint and response statistics across sets of exercises.

• Refactor

  • Aggregations and queries standardized to use explicit exercise identifiers for consistency.

• Tests

  • Test fixtures and utilities updated to associate results with exercises and adjust timestamps for reliable stats.

[florian-glombik]

Code

[github-actions]

End-to-End (E2E) Test Results Summary

	Tests	Passed ✅	Skipped	Failed	Time ⏱
End-to-End (E2E) Test Report	1 ran	1 passed	0 skipped	0 failed	1s 852ms

Test	Result	Time ⏱
No test annotations available

[github-actions]

End-to-End (E2E) Test Results Summary

	Tests	Passed ✅	Skipped	Failed	Time ⏱
End-to-End (E2E) Test Report	1 ran	1 passed	0 skipped	0 failed	1s 654ms

Test	Result	Time ⏱
No test annotations available

[bensofficial]

DB migration

[florian-glombik]

Re-approve code

[bensofficial]

Reapprove DB migration

[github-actions]

End-to-End (E2E) Test Results Summary

	Tests	Passed ✅	Skipped	Failed	Time ⏱
End-to-End (E2E) Test Report	1 ran	1 passed	0 skipped	0 failed	1s 721ms

Test	Result	Time ⏱
No test annotations available

[github-actions]

End-to-End (E2E) Test Results Summary

	Tests	Passed ☑️	Skipped ⚠️	Failed ❌️	Time ⏱
End-to-End (E2E) Test Report	205 ran	199 passed	3 skipped	3 failed	1h 15m 36s 471ms

Test	Result	Time ⏱
End-to-End (E2E) Test Report
e2e/exercise/quiz-exercise/QuizExerciseManagement.spec.ts
ts.Quiz Exercise Management › Quiz Exercise Creation › Creates a Quiz with Drag and Drop	❌ failure	2m 4s 892ms
e2e/exam/test-exam/TestExamParticipation.spec.ts
ts.Test exam participation › Early Hand-in › Using exercise overview to navigate within exam	❌ failure	4m 38s 563ms
e2e/exercise/programming/ProgrammingExerciseStaticCodeAnalysis.spec.ts
ts.Static code analysis tests › Configures SCA grading and makes a successful submission with SCA errors	❌ failure	2m 41s 444ms

[MoritzSpengler]

Tested on TS1. First deployed develop and took screenshots of the values. Then deployed the branch and compared the values, which are correct. For future devs here are the screenshots from develop for my course (Moritz Spengler).

[github-actions]

End-to-End (E2E) Test Results Summary

	Tests	Passed ☑️	Skipped ⚠️	Failed ❌️	Time ⏱
End-to-End (E2E) Test Report	205 ran	201 passed	3 skipped	1 failed	1h 15m 49s 305ms

Test	Result	Time ⏱
End-to-End (E2E) Test Report
e2e/exercise/programming/ProgrammingExerciseStaticCodeAnalysis.spec.ts
ts.Static code analysis tests › Configures SCA grading and makes a successful submission with SCA errors	❌ failure	2m 41s 145ms