Skip to content

Conversation

b-fein
Copy link
Contributor

@b-fein b-fein commented Oct 13, 2025

Checklist

General

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
  • I strictly followed the principle of data economy for all client-server REST calls.
  • I strictly followed the client coding and design guidelines.
  • I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
  • I documented the TypeScript code using JSDoc style.

Changes affecting Programming Exercises

  • High priority: I tested all changes and their related features with all corresponding user types on a test server configured with the integrated lifecycle setup (LocalVC and LocalCI).
  • I tested all changes and their related features with all corresponding user types on a test server configured with LocalVC and Jenkins.

Motivation and Context

Closes #11486.

High priority: Without this fix, programming exercises cannot be fully set up in Artemis instances that use Jenkins. Especially relevant now as the semester started.

In commit 54d40a7 the event type for the code changed event was modified.

The types in the build plan editor component were not updated to reflect this change.

Description

Updates the build plan editor component to use the correct types.

Steps for Testing

Prerequisites:

  • 1 Instructor
  • 1 Programming Exercise in a Jenkins setup
  1. Go to the programming exercise details page, from there go to the ‘Edit Build Plan’ page (button cluster at the top).
  2. Make changes to the build plan.
  3. Submitting the build plan should work.

Testserver States

You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Test Coverage

Class/File Line Coverage Confirmation (assert/expect)
build-plan-editor.component.ts unchanged

@coderabbitai ignore

@b-fein b-fein requested a review from a team as a code owner October 13, 2025 09:40
@github-project-automation github-project-automation bot moved this to Work In Progress in Artemis Development Oct 13, 2025
@b-fein b-fein moved this from Work In Progress to Ready For Review in Artemis Development Oct 13, 2025
@github-actions github-actions bot added client Pull requests that update TypeScript code. (Added Automatically!) programming Pull requests that affect the corresponding module labels Oct 13, 2025
@b-fein b-fein added this to the 8.5.0 milestone Oct 13, 2025

This comment was marked as spam.

Copy link

End-to-End (E2E) Test Results Summary

TestsPassed ☑️Skipped ⚠️Failed ❌️Time ⏱
End-to-End (E2E) Test Report205 ran200 passed3 skipped2 failed1h 12m 34s 374ms
TestResultTime ⏱
End-to-End (E2E) Test Report
e2e/exercise/quiz-exercise/QuizExerciseParticipation.spec.ts
ts.Quiz Exercise Participation › DnD Quiz participation › Student can participate in DnD Quiz❌ failure2m 4s 957ms
e2e/exam/test-exam/TestExamStudentExams.spec.ts
ts.Test Exam - student exams › Check exam participants and their submissions › Search for a student in exams❌ failure6m 8s 656ms

@b-fein b-fein requested a review from dfuchss October 13, 2025 17:56
Copy link
Contributor

@dfuchss dfuchss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm

Copy link

End-to-End (E2E) Test Results Summary

TestsPassed ☑️Skipped ⚠️Failed ❌️Time ⏱
End-to-End (E2E) Test Report205 ran201 passed3 skipped1 failed1h 10m 16s 254ms
TestResultTime ⏱
End-to-End (E2E) Test Report
e2e/exam/test-exam/TestExamStudentExams.spec.ts
ts.Test Exam - student exams › Check exam participants and their submissions › Open the list of exam students❌ failure6m 7s 227ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix client Pull requests that update TypeScript code. (Added Automatically!) priority:high programming Pull requests that affect the corresponding module ready for review small

Projects

Status: Ready For Review

Development

Successfully merging this pull request may close these issues.

Editing build plans result in a 400 Response

2 participants