Communication: Fix message cut in half while sending issue

[ayca-cevdet]

Summary

Checklist

General

• This is a small issue that I tested locally.
• I chose a title conforming to the naming conventions for pull requests.

Client

• I strictly followed the client coding guidelines.
• I strictly followed the AET UI-UX guidelines.

Motivation and Context

It fixes the issue #12029.
There was a timing issue occurred by having a delay for updating the message. Currently if user hits enter or clicks on send button quickly, the message was sent as 'cut in half'.

Description

I added a delay in creatingPost function to wait for update message events to emit successfully before sending it.

Steps for Testing

1. Go to a random DM
2. Write something and hit enter immediately, quickly
3. Repeat few more times
4. See messages are sent correctly in full

Testserver States

You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.

Review Progress

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

Screenshots

Summary by CodeRabbit

• Bug Fixes
  • Introduced a short delay before sending messages to synchronize with the editor’s processing, preventing premature posts.
  • Updated tests to wait for the new delay so asynchronous success/error paths are reliably validated.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Adds a 250ms delay before creating a post in the message inline input component to wait for the markdown editor's textChangedEmitDelay; corresponding unit tests updated to advance time by 300ms to accommodate the delay.

Changes

Cohort / File(s)	Summary
Message Input Timing Fix src/main/webapp/app/communication/message/message-inline-input/message-inline-input.component.ts	Wraps posting creation in a 250ms setTimeout to ensure the editor's text change has propagated before setting posting.content and calling createPost; success/error handling unchanged.
Tests: Async Tick Adjustment src/main/webapp/app/communication/message/message-inline-input/message-inline-input.component.spec.ts	Advances tick() calls to tick(300) in tests to wait for the introduced 250ms delay before asserting createPost behavior for success and error paths.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly and clearly describes the main fix: resolving the message cut-in-half timing issue. It accurately reflects the core change in the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch bugfix/communication/sending-message-timing-issue

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

End-to-End (E2E) Test Results Summary

	Tests	Passed ☑️	Skipped ⚠️	Failed ❌️	Time ⏱
End-to-End (E2E) Test Report	223 ran	220 passed	1 skipped	2 failed	1h 45m 44s 568ms

Test	Result	Time ⏱
End-to-End (E2E) Test Report
e2e/course/CourseMessages.spec.ts
ts.Course messages › Channel messages › Write/edit/delete message in channel › Student should be able to write message in channel	❌ failure	2m 20s 223ms
e2e/exam/ExamTestRun.spec.ts
ts.Exam test run › Delete a test run › Deletes a test run	❌ failure	2m 42s 653ms

[coderabbitai]

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/main/webapp/app/communication/message/message-inline-input/message-inline-input.component.spec.ts (1)

203-217: Rename test or switch to creation test data to match test name.

The test at lines 203-217 is named "should clear draft after successful post creation", but the beforeEach (line 143) uses directMessageUser1—an existing message with id: 9. This triggers the update path, not the creation path. The test is functionally correct (update has no tick(300) delay), but the name is misleading.

Either:

1. Rename to "should clear draft after successful post update" to reflect actual behavior, or
2. Switch to metisPostToCreateUser1 and add tick(300) to test the creation path as the name implies.

🧹 Nitpick comments (1)

src/main/webapp/app/communication/message/message-inline-input/message-inline-input.component.spec.ts (1)

69-76: Consider adding a comment to explain the 300ms delay.

The tick(300) accommodates the 250ms delay in the component's confirm() method, but this relationship isn't immediately obvious. A brief comment would help future maintainers understand why this specific value is used and prevent accidental breakage if the component's delay changes.

         component.confirm();
+        // Wait for the 250ms textChangedEmitDelay in the component before the service call
         tick(300);

[github-actions]

End-to-End (E2E) Test Results Summary

	Tests	Passed ☑️	Skipped ⚠️	Failed ❌️	Time ⏱
End-to-End (E2E) Test Report	223 ran	218 passed	1 skipped	4 failed	1h 49m 42s 935ms

Test	Result	Time ⏱
End-to-End (E2E) Test Report
e2e/course/CourseMessages.spec.ts
ts.Course messages › Channel messages › Write/edit/delete message in channel › Student should be able to write message in channel	❌ failure	2m 22s 883ms
e2e/exercise/modeling/ModelingExerciseManagement.spec.ts
ts.Modeling Exercise Management › Create Modeling Exercise › Create a new modeling exercise	❌ failure	2m 4s 91ms
e2e/exam/test-exam/TestExamParticipation.spec.ts
ts.Test exam participation › Early Hand-in › Using exercise sidebar to navigate within exam	❌ failure	4m 45s 470ms
ts.Test exam participation › Early Hand-in › Using exercise overview to navigate within exam	❌ failure	4m 42s 393ms

[atharvamp]

Tested on TS6, works as intended. Messages are no longer cut off after clicking enter.

[anian03]

Tested o TS6. While the issue no longer persists, I'm not sure if this is the best solution as it makes the web app seem slower. Do you know if there is a way to wait until the test update was complete? That way it would be ≤200ms, no always exactly 250ms

[NadiaCurumi]

Tested on TS6
Messges are not cut in half when pressing send.

[lana-ati]

Tested during working session on TS3. Worked as expected.

[kristi-balla]

tested on t3, works as expected

[oTaczkowski]

Tested on TS3, everything works.

[hanna20022005]

tested on ts3 using tsest user 18, works as intended ^^

2026-01-28.10-50-21.mp4