-
Notifications
You must be signed in to change notification settings - Fork 358
Development: Update links from old documentation to new documentation
#12041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Development: Update links from old documentation to new documentation
#12041
Conversation
WalkthroughConsolidates documentation link migrations to docs.artemis.tum.de, moves Integrated Code Lifecycle Setup from developer to admin docs (new file), renames "Textual Exercise" to "Text Exercise" across docs and UI mappings, updates Docusaurus config and a dev dependency, and edits several comment/Javadoc URLs. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This reverts commit fd7d8f1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
documentation/package.json (1)
32-37: Clarify whybaseline-browser-mappingis explicitly listed as a devDependency.
[email protected]is already pulled in as a transitive dependency ofbrowserslist(which specifies^2.9.0). Explicitly adding it as a direct devDependency appears redundant unless there's a specific need for it in the documentation build process. Either remove it and rely on the transitive dependency, or add a comment explaining why it must be directly specified.(No security vulnerabilities were found for this package.)
🤖 Fix all issues with AI agents
In
`@documentation/docs/admin/production-setup/integrated-code-lifecycle-setup.mdx`:
- Around line 32-41: The snippet currently hard-codes "image-architecture:
arm64" under the continuous-integration section which will break amd64 users if
copy/pasted; change the documentation so "image-architecture: arm64" is not set
as a default — either remove or comment out that line and add a short note
beside the continuous-integration or image-architecture entry instructing
readers to set image-architecture to "arm64" only on ARM systems (e.g., Apple
M-series, Raspberry Pi) and otherwise leave it unset for the default amd64.
documentation/docs/admin/production-setup/integrated-code-lifecycle-setup.mdx
Show resolved
Hide resolved
End-to-End (E2E) Test Results Summary
|
||||||||||||||||||||||||
End-to-End (E2E) Test Results Summary
|
||||||||||||||||||
Development: Update links from to old documentation to link new documentationDevelopment: Update links from old documentation to new documentation
End-to-End (E2E) Test Results Summary
|
||||||||||||||||||||||||
atharvamp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally.
In step 4 of testing instructions, the new page no longer has common setup problems which has been moved to setup guide, just making sure this is intentional.
In step 5, the link http://localhost:3000/admin/production-setup/jenkins-localvc leads to a Page Not Found.
In step 6, the hyperlink Text Exercises leads to the page Textual Exercises. I think it's better to just align on one Textual or Text. Personally, I think Text is better.
DominikRemo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested localy and reviewed the code. Looks quite good already. I left you two comments.
Also, one of the links in the pr description should be http://localhost:3000/admin/jenkins-localvc, but it is http://localhost:3000/admin/production-setup/jenkins-localvc (see step 5 in the Steps for Testing).
...java/de/tum/cit/aet/artemis/communication/linkpreview/mockFiles/github_pull_request_6615.txt
Outdated
Show resolved
Hide resolved
...java/de/tum/cit/aet/artemis/communication/linkpreview/mockFiles/github_pull_request_6615.txt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
🤖 Fix all issues with AI agents
In
`@documentation/docs/admin/production-setup/programming-exercise-adjustments.mdx`:
- Line 385: The link text "Integrated Code Lifecycle Setup" in
production-setup/programming-exercise-adjustments.mdx is using a different path;
update the markdown link target so it matches the admin section path style used
earlier (the same form as the link at line 315). Locate the phrase "Integrated
Code Lifecycle Setup" in the file and change its href to the admin section path
used at line 315 so all three occurrences (lines ~315, ~339/~360, and this one)
use the same target.
- Line 360: The link "Integrated Code Lifecycle Setup" in this line uses the
developer path (/developer/setup#integrated-code-lifecycle-setup) which is
inconsistent with the admin path used elsewhere; update this instance to use the
admin path (/admin/setup#integrated-code-lifecycle-setup) so all links to the
Integrated Code Lifecycle Setup are consistent across the document.
- Line 416: The link text "[Integrated Code Lifecycle
Setup](/developer/setup#integrated-code-lifecycle-setup)" is inconsistently
pointing to the developer setup; update all four occurrences of that link (the
instances on the page containing the phrase "Integrated Code Lifecycle Setup")
to point to the admin section URL instead (replace the
/developer/setup#integrated-code-lifecycle-setup href with the corresponding
admin anchor), ensuring all four instances are changed consistently and link to
the correct admin documentation location.
- Line 339: Replace all occurrences of the outdated link path
"/developer/setup#integrated-code-lifecycle-setup" in this file with the correct
admin path "/admin/production-setup/integrated-code-lifecycle-setup" (these
appear multiple times around the mentions of Integrated Code Lifecycle Setup and
match other references such as the one already using the admin path); update
each markdown link target so the display text remains the same but the href
points to the new "/admin/production-setup/integrated-code-lifecycle-setup"
location to ensure consistency with integrated-code-lifecycle-setup.mdx and
other docs.
documentation/docs/admin/production-setup/programming-exercise-adjustments.mdx
Outdated
Show resolved
Hide resolved
documentation/docs/admin/production-setup/programming-exercise-adjustments.mdx
Outdated
Show resolved
Hide resolved
documentation/docs/admin/production-setup/programming-exercise-adjustments.mdx
Outdated
Show resolved
Hide resolved
documentation/docs/admin/production-setup/programming-exercise-adjustments.mdx
Outdated
Show resolved
Hide resolved
|
@florian-glombik Test coverage has been automatically updated in the PR description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
`@documentation/docs/admin/production-setup/programming-exercise-adjustments.mdx`:
- Around line 315-317: Update the first link target for "Integrated Code
Lifecycle Setup" so it matches the new dedicated page used elsewhere in this
file: replace the current URL that points to
/admin/production-setup/multiple-artemis-instances#integrated-code-lifecycle
with the dedicated integrated code lifecycle page (the same slug used by other
links in this document, e.g.,
/admin/production-setup/integrated-code-lifecycle-setup) and verify the anchor
text "Integrated Code Lifecycle Setup" and the second link to "timeout options"
remain correct and consistent.
| This setting is relevant only when using [Integrated Code Lifecycle Setup](/admin/production-setup/multiple-artemis-instances#integrated-code-lifecycle). | ||
|
|
||
| You can adjust possible [timeout options](https://docs.artemis.cit.tum.de/user/exercises/programming.html#edit-maximum-build-duration) for the build process in Integrated Code Lifecycle Setup. | ||
| You can adjust possible [timeout options](/admin/production-setup/programming-exercise-adjustments#timeout-options) for the build process in Integrated Code Lifecycle Setup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Align Integrated Code Lifecycle link with the new dedicated page.
Line 315 still points to the multi-node page anchor, while the rest of this file links to the new Integrated Code Lifecycle Setup page. If the content moved, this is inconsistent and likely confusing. Consider pointing this to the same dedicated page.
🔧 Suggested update
-This setting is relevant only when using [Integrated Code Lifecycle Setup](/admin/production-setup/multiple-artemis-instances#integrated-code-lifecycle).
+This setting is relevant only when using [Integrated Code Lifecycle Setup](./integrated-code-lifecycle-setup.mdx).🤖 Prompt for AI Agents
In
`@documentation/docs/admin/production-setup/programming-exercise-adjustments.mdx`
around lines 315 - 317, Update the first link target for "Integrated Code
Lifecycle Setup" so it matches the new dedicated page used elsewhere in this
file: replace the current URL that points to
/admin/production-setup/multiple-artemis-instances#integrated-code-lifecycle
with the dedicated integrated code lifecycle page (the same slug used by other
links in this document, e.g.,
/admin/production-setup/integrated-code-lifecycle-setup) and verify the anchor
text "Integrated Code Lifecycle Setup" and the second link to "timeout options"
remain correct and consistent.
|
@florian-glombik Your PR description needs attention before it can be reviewed: Issues Found
How to Fix
This check validates that your PR description follows the PR template. A complete description helps reviewers understand your changes and speeds up the review process.
|
|
@florian-glombik Test coverage has been automatically updated in the PR description. |
End-to-End (E2E) Test Results Summary
|
||||||||||||||||||||||||||||||
Summary
Checklist
General
Motivation and Context
Description
Integrated Code Lifecyclesection andJenkins and LocalVC setupto administrator sectionTextualvsTextexercisesSteps for Testing
cd documentationand thennpm install && npm run build && npm run serveReview Progress
Code Review
Manual Tests
Test Coverage
Client
Server
Last updated: 2026-01-28 12:22:01 UTC