Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Switch postgres e2e setup to Jenkins/Gitlab #6948

Merged
merged 14 commits into from
Jul 25, 2023

Conversation

TheZoker
Copy link
Contributor

Checklist

General

Motivation and Context

We are currently only testing the E2E test with the Atlassian suite (bamboo, bitbucket, jira).

Description

This PR switches the postgres E2E plan to using Gitlab and Jenkins. It also fixes the gitlab health check and adds local user management (necessary users are created before each run).

Review Progress

Code Review

  • Review 1
  • Review 2

@TheZoker TheZoker requested a review from a team as a code owner July 21, 2023 00:33
@github-actions github-actions bot added tests server Pull requests that update Java code. (Added Automatically!) cypress Pull requests that update cypress tests. (Added Automatically!) docker labels Jul 21, 2023
@TheZoker TheZoker force-pushed the test/cypress/switch-postgres-to-jenkins-gitlab branch 3 times, most recently from 9395e67 to 819d539 Compare July 21, 2023 09:50
Copy link
Contributor

@Strohgelaender Strohgelaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR makes the server tests running for over one hour and probally get stuck somewhere.

@TheZoker TheZoker force-pushed the test/cypress/switch-postgres-to-jenkins-gitlab branch from 6662db0 to 2912b41 Compare July 21, 2023 14:11
pal03377
pal03377 previously approved these changes Jul 25, 2023
Copy link
Contributor

@pal03377 pal03377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! Also, the health status of GitLab will be fixed 🎉

src/test/cypress/support/users.ts Show resolved Hide resolved
pal03377
pal03377 previously approved these changes Jul 25, 2023
@TheZoker TheZoker force-pushed the test/cypress/switch-postgres-to-jenkins-gitlab branch from 03b3f33 to 2673202 Compare July 25, 2023 14:43
@TheZoker TheZoker requested a review from pal03377 July 25, 2023 14:44
Copy link
Contributor

@tobias-lippert tobias-lippert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@TheZoker TheZoker added this to the 6.3.8 milestone Jul 25, 2023
@krusche krusche changed the title Development: Switch Postgres E2E Setup to Jenkins/Gitlab Development: Switch postgres e2e setup to Jenkins/Gitlab Jul 25, 2023
@krusche krusche merged commit ecab7ce into develop Jul 25, 2023
21 of 23 checks passed
@krusche krusche deleted the test/cypress/switch-postgres-to-jenkins-gitlab branch July 25, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress Pull requests that update cypress tests. (Added Automatically!) docker ready to merge server Pull requests that update Java code. (Added Automatically!) tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants