Development: Speedup cypress e2e tests
#6960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st/cypress-delay
…st/cypress-delay
github-actions
bot
added
tests
cypress
pal03377
approved these changes
Jul 22, 2023
Contributor
pal03377
left a comment
pal03377
left a comment
There was a problem hiding this comment.
Thanks for this improvement! 🏎️ Code changes look good & E2E tests still pass.
I have one additional suggestion that might improve the speed even a slight bit more below, but if that does not work I'm also happy with the current changes.
TheZoker
approved these changes
Jul 23, 2023
Contributor
TheZoker
left a comment
TheZoker
left a comment
There was a problem hiding this comment.
Changes look good to me 👍
krusche
changed the title
Development: Speedup cypress testsDevelopment: Speedup cypress e2e tests
bensofficial
pushed a commit
that referenced
this pull request
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Motivation and Context
The cypress tests are quite long-running, which leads to a large bamboo queue.
Description
This PR reduces the runtime by about 10 minutes by doing the following:
Deleting a course sometimes fails due to some scheduled work on the server. Instead of waiting for constant 20 seconds, we wait a short period and use
retryOnStatusCodeFailureto submit another request in case the request failed.By wrapping login attempts into a
cy.session()call, the created authorization token gets saved and can get reused in later tests. We don't need to use and test the login endpoint every time.With
testIsolation: falsewe no longer restart the browser between every test, leading to better runtime and (in my opinion) more realistic tests since the user also does not restart the browser before every action.Steps for Testing
code review
Review Progress
Code Review
Screenshots