Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lectures: Add status bar to lecture creation and edit mode #9655

Draft
wants to merge 51 commits into
base: develop
Choose a base branch
from
Draft

Lectures: Add status bar to lecture creation and edit mode #9655

wants to merge 51 commits into from
+347 −194

Commits on Nov 2, 2024

  1. Adhere to standard structure in lecture-update.component.ts

    @florian-glombik
    florian-glombik committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    dc9acd1 View commit details
    Browse the repository at this point in the history

  2. Refactor existing component

    @florian-glombik
    florian-glombik committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    9474b66 View commit details
    Browse the repository at this point in the history

  3. Icons needed for test

    @florian-glombik
    florian-glombik committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    1c46b24 View commit details
    Browse the repository at this point in the history

  4. Refactor comment to renamed method

    @florian-glombik
    florian-glombik committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    504db17 View commit details
    Browse the repository at this point in the history

  5. Start adding the status bar

    @florian-glombik
    florian-glombik committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    8292a58 View commit details
    Browse the repository at this point in the history

  6. Introduce more signals, mark non signals as deprecated

    @florian-glombik
    florian-glombik committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    f3e8b14 View commit details
    Browse the repository at this point in the history

  7. Fix error by adding titleChannelNameComponent child

    @florian-glombik
    florian-glombik committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    52bf471 View commit details
    Browse the repository at this point in the history

  8. Make all information available on one page (no course set not handled… 

    … yet)
    @florian-glombik
    florian-glombik committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    2e1a07f View commit details
    Browse the repository at this point in the history

  9. Introducing more signals

    @florian-glombik
    florian-glombik committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    e444f19 View commit details
    Browse the repository at this point in the history

  10. Retrieving form valid from video unit form and get rid of method call… 

    … in template
    @florian-glombik
    florian-glombik committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    91be135 View commit details
    Browse the repository at this point in the history

  11. Retrieving form valid from online unit form and get rid of method cal… 

    …l in template
    @florian-glombik
    florian-glombik committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    166ee38 View commit details
    Browse the repository at this point in the history

  12. Retrieving form valid from attachment unit form and get rid of method… 

    … call in template
    @florian-glombik
    florian-glombik committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    8ddbd9e View commit details
    Browse the repository at this point in the history

  13. Forward unit valid state to status bar

    @florian-glombik
    florian-glombik committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    4066e34 View commit details
    Browse the repository at this point in the history

  14. Fixing accessing signals

    @florian-glombik
    florian-glombik committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    7f5d8a9 View commit details
    Browse the repository at this point in the history

  15. Fixing statusbar state for units when no unit dialog is open

    @florian-glombik
    florian-glombik committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    35e4778 View commit details
    Browse the repository at this point in the history

  16. Add note for needed changes in lecture-update.component.html

    @florian-glombik
    florian-glombik committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    b4617c5 View commit details
    Browse the repository at this point in the history

  17. Use signal instead of subscription

    @florian-glombik
    florian-glombik committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    6998fbd View commit details
    Browse the repository at this point in the history

  18. Use signal instead of subscription: video-unit-form.component.ts

    @florian-glombik
    florian-glombik committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    9b20757 View commit details
    Browse the repository at this point in the history

  19. Use signal instead of subscription: online-unit-form.component.ts

    @florian-glombik
    florian-glombik committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    30e6d2d View commit details
    Browse the repository at this point in the history

  20. Use signal instead of subscription: attachment-unit-form.component.ts

    @florian-glombik
    florian-glombik committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    6671e52 View commit details
    Browse the repository at this point in the history

  21. Use signals in datepicker

    @florian-glombik
    florian-glombik committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    e066a2a View commit details
    Browse the repository at this point in the history

  22. Finally using signals in datepicker

    @florian-glombik
    florian-glombik committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    50ba4c2 View commit details
    Browse the repository at this point in the history

  23. Fix StatusBar computation of period value

    @florian-glombik
    florian-glombik committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    ebce6d5 View commit details
    Browse the repository at this point in the history

  24. Add comment on adjustment within edit mode

    @florian-glombik
    florian-glombik committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    289b79f View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Fix signal call

    @florian-glombik
    florian-glombik committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    80862a8 View commit details
    Browse the repository at this point in the history

  2. Make links clickable

    @florian-glombik
    florian-glombik committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    3f77061 View commit details
    Browse the repository at this point in the history

  3. Use signals for date-time-picker.component.ts

    @florian-glombik
    florian-glombik committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    c638460 View commit details
    Browse the repository at this point in the history

  4. Introduce signal for easy retrieval of valid state

    @florian-glombik
    florian-glombik committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    026a570 View commit details
    Browse the repository at this point in the history

  5. Fix tests for date-time-picker.component.ts

    @florian-glombik
    florian-glombik committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    9b954b2 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Merge remote-tracking branch 'origin/develop' into develop

    @florian-glombik
    florian-glombik committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    c9ca46b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into feature/lectures/add-status-bar 

    # Conflicts:
#	src/main/webapp/app/lecture/lecture-attachments.component.ts
#	src/main/webapp/app/lecture/lecture-unit/lecture-unit-management/attachment-unit-form/attachment-unit-form.component.ts
#	src/main/webapp/app/lecture/lecture-unit/lecture-unit-management/create-exercise-unit/create-exercise-unit.component.ts
#	src/main/webapp/app/lecture/lecture-unit/lecture-unit-management/online-unit-form/online-unit-form.component.ts
#	src/main/webapp/app/lecture/lecture-unit/lecture-unit-management/text-unit-form/text-unit-form.component.ts
#	src/main/webapp/app/lecture/lecture-update.component.ts
#	src/main/webapp/app/shared/date-time-picker/date-time-picker.component.html
#	src/main/webapp/app/shared/date-time-picker/date-time-picker.component.ts
#	src/main/webapp/app/shared/form/title-channel-name/title-channel-name.component.ts
    @florian-glombik
    florian-glombik committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    956d4e0 View commit details
    Browse the repository at this point in the history

  3. Place import at same place as before merge to reduce diff

    @florian-glombik
    florian-glombik committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    7848fc5 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/develop' into develop

    @florian-glombik
    florian-glombik committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    ad22a0c View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into feature/lectures/add-status-bar 

    # Conflicts:
#	src/main/webapp/app/lecture/lecture-unit/lecture-unit-management/video-unit-form/video-unit-form.component.ts
    @florian-glombik
    florian-glombik committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    3644f68 View commit details
    Browse the repository at this point in the history

  6. Undo renaming to reduce the potential of merge conflicts and minimize… 

    … the diff
    @florian-glombik
    florian-glombik committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    ba2851e View commit details
    Browse the repository at this point in the history

  7. Fix inconsistency of naming in client test description

    @florian-glombik
    florian-glombik committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    c5f7164 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2024

  1. Merge branch 'develop' into feature/lectures/add-status-bar 

    # Conflicts:
#	src/main/webapp/app/shared/date-time-picker/date-time-picker.component.html
#	src/main/webapp/app/shared/date-time-picker/date-time-picker.component.ts
    @florian-glombik
    florian-glombik committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    d4e13af View commit details
    Browse the repository at this point in the history

  2. Add section titles and display all steps

    @florian-glombik
    florian-glombik committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    cce1353 View commit details
    Browse the repository at this point in the history

  3. Display all sections

    @florian-glombik
    florian-glombik committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    0c08b38 View commit details
    Browse the repository at this point in the history

  4. Consider date validation in text unit form

    @florian-glombik
    florian-glombik committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    d525213 View commit details
    Browse the repository at this point in the history

  5. Consider date for validity changes

    @florian-glombik
    florian-glombik committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    84797cc View commit details
    Browse the repository at this point in the history

  6. Change title based on editing / creating lecture

    @florian-glombik
    florian-glombik committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    6c06ff4 View commit details
    Browse the repository at this point in the history

  7. Fix code smell

    @florian-glombik
    florian-glombik committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    2ad54cf View commit details
    Browse the repository at this point in the history

  8. Fix attachment creation for new lecture

    @florian-glombik
    florian-glombik committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    2859b69 View commit details
    Browse the repository at this point in the history

  9. Use signal for lecture

    @florian-glombik
    florian-glombik committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    0f3f54f View commit details
    Browse the repository at this point in the history

  10. Fix attachments within lecture create view

    @florian-glombik
    florian-glombik committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    d5b5dd0 View commit details
    Browse the repository at this point in the history

  11. Fix console errors

    @florian-glombik
    florian-glombik committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    261b058 View commit details
    Browse the repository at this point in the history

  12. Delete lecture on cancel in create mode

    @florian-glombik
    florian-glombik committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    1a2fe16 View commit details
    Browse the repository at this point in the history

  13. Do not display alert when deleting lecture in the background

    @florian-glombik
    florian-glombik committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    1f7d0b7 View commit details
    Browse the repository at this point in the history

  14. Wait with navigation back to ensure the old lecture is not displayed … 

    …in the list
    @florian-glombik
    florian-glombik committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    8bd8bef View commit details
    Browse the repository at this point in the history

  15. Fix error alert when cancelling the lecture creation

    @florian-glombik
    florian-glombik committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    5ced798 View commit details
    Browse the repository at this point in the history