fix confirmation and is_finished

ls1intum · Nov 12, 2024 · d73a07f · d73a07f
1 parent af8c89e
commit d73a07f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/playground/src/pages/[expert_evaluation_config_id]/[expert_id]/expert_view.tsx b/playground/src/pages/[expert_evaluation_config_id]/[expert_id]/expert_view.tsx
@@ -117,7 +117,7 @@ export default function SideBySideExpertView() {
       confirmed = confirm("Are you sure want to continue with the next submission? You did not yet evaluate all metrics!");
     }
 
-    if (globalSubmissionIndex === submissionsLength - 1) {
+    if (globalSubmissionIndex === submissionsLength - 1 && confirmed) {
       confirmed = confirm("Are you sure you want to finish the evaluation? Once you finish, you can no longer make any changes!");
     }
 
@@ -144,7 +144,7 @@ export default function SideBySideExpertView() {
     if (currentSubmissionIndex > 0) {
       saveProgress();
     }
-  }, [currentSubmissionIndex]);
+  }, [currentSubmissionIndex, isFinishedEvaluating]);
 
   const handlePrevious = () => {
     // If we are not at the first submission, just decrement the submission index