-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preliminary AI Feedback for all Apollon UML Diagrams #335
Merged
FelixTJDietrich
merged 17 commits into
develop
from
feature/modeling-feedback-all-diagram-types
Sep 12, 2024
Merged
Preliminary AI Feedback for all Apollon UML Diagrams #335
FelixTJDietrich
merged 17 commits into
develop
from
feature/modeling-feedback-all-diagram-types
Sep 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
deployment-error
Added by deployment workflows if an error occured
and removed
deploy:athena-test2
Athena Test Server 2
labels
Sep 6, 2024
LeonWehrhahn
added
deploy:athena-test2
Athena Test Server 2
and removed
deployment-error
Added by deployment workflows if an error occured
labels
Sep 8, 2024
github-actions
bot
added
deployment-error
Added by deployment workflows if an error occured
and removed
deploy:athena-test2
Athena Test Server 2
labels
Sep 8, 2024
LeonWehrhahn
added
deploy:athena-test2
Athena Test Server 2
and removed
deployment-error
Added by deployment workflows if an error occured
labels
Sep 8, 2024
github-actions
bot
added
deployment-error
Added by deployment workflows if an error occured
and removed
deploy:athena-test2
Athena Test Server 2
labels
Sep 8, 2024
LeonWehrhahn
added
deploy:athena-test2
Athena Test Server 2
and removed
deployment-error
Added by deployment workflows if an error occured
labels
Sep 8, 2024
LeonWehrhahn
temporarily deployed
to
athena-test2.ase.cit.tum.de
September 8, 2024 04:34
— with
GitHub Actions
Inactive
github-actions
bot
added
lock:athena-test2
Is currently deployed to Athena Test Server 2
and removed
deploy:athena-test2
Athena Test Server 2
labels
Sep 8, 2024
LeonWehrhahn
changed the title
Rewrite Modeling Module to process all UML Diagram types
Preliminary AI Feedback for all Apollon UML Diagrams
Sep 8, 2024
LeonWehrhahn
removed
the
lock:athena-test2
Is currently deployed to Athena Test Server 2
label
Sep 8, 2024
LeonWehrhahn
added
deploy:athena-test1
Athena Test Server 1
deploy:athena-test2
Athena Test Server 2
and removed
lock:athena-test2
Is currently deployed to Athena Test Server 2
labels
Sep 12, 2024
LeonWehrhahn
temporarily deployed
to
athena-test1.ase.cit.tum.de
September 12, 2024 11:42
— with
GitHub Actions
Inactive
LeonWehrhahn
temporarily deployed
to
athena-test2.ase.cit.tum.de
September 12, 2024 11:42
— with
GitHub Actions
Inactive
github-actions
bot
added
lock:athena-test2
Is currently deployed to Athena Test Server 2
lock:athena-test1
Is currently deployed to Athena Test Server 1
and removed
deploy:athena-test1
Athena Test Server 1
labels
Sep 12, 2024
LeonWehrhahn
temporarily deployed
to
athena-test2.ase.cit.tum.de
September 12, 2024 11:53
— with
GitHub Actions
Inactive
FelixTJDietrich
requested changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LeonWehrhahn
added
deploy:athena-test1
Athena Test Server 1
and removed
lock:athena-test1
Is currently deployed to Athena Test Server 1
lock:athena-test2
Is currently deployed to Athena Test Server 2
labels
Sep 12, 2024
|
github-actions
bot
added
the
deployment-error
Added by deployment workflows if an error occured
label
Sep 12, 2024
FelixTJDietrich
added
deploy:athena-test1
Athena Test Server 1
and removed
deployment-error
Added by deployment workflows if an error occured
labels
Sep 12, 2024
FelixTJDietrich
temporarily deployed
to
athena-test1.ase.cit.tum.de
September 12, 2024 18:29
— with
GitHub Actions
Inactive
github-actions
bot
added
lock:athena-test1
Is currently deployed to Athena Test Server 1
and removed
deploy:athena-test1
Athena Test Server 1
labels
Sep 12, 2024
FelixTJDietrich
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
FelixTJDietrich
deleted the
feature/modeling-feedback-all-diagram-types
branch
September 12, 2024 18:34
github-actions
bot
removed
the
lock:athena-test1
Is currently deployed to Athena Test Server 1
label
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The initial version of the module_modeling_llm was designed to primarily handle BPMN Diagrams. This enhanced implementation uses a new way to parse UML diagrams with a more generic approach making it work with all Apollon supported diagram types. The module has also been updated to utilize Langchain 0.2.15, which allows for the use of native structured output with json_mode for the latest OpenAI models. Additionally, it now supports both graded and non-graded feedback, ensuring that exercise solutions are not revealed when a student requests feedback.
Description
The new Apollon UML parser converts Apollon JSON into a text representation similar to Mermaid. This representation retains only the most essential attributes of a UML diagram, such as elements, the relationships between them, and the properties/methods associated with these elements and relationships.
Since the module was originally built using an older version of Langchain, the code interfacing with Langchain has been rewritten to leverage the new LCE framework. This update also allows for the use of native structured output, eliminating the need to rely on function calling to obtain valid JSON.
The module now also differentiates between graded and non-graded feedback. The
is_graded
parameter is set totrue
on the Artemis side when a tutor requests feedback suggestions. When a student requests feedback,is_graded
is set tofalse
. Ifis_graded
isfalse
, the feedback output is passed through a filter which rewrites the title and descriptions to avoid giving away the solution.Example: Here we send a student's diagram submission where the start event of a BPMN diagram is missing:
is_graded = true:
is_graded = false:
Steps for Testing
Option 1: API Testing:
/feedback_suggestions
endpoint of the module.is_graded = true
andis_graded = false
scenarios.Option 2. Athena Playground Testing:
/feedback_suggestions
endpoint.is_graded = true
:is_graded = false
:Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Screenshots