Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Fix linting issues #352

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Conversation

dmytropolityka
Copy link
Contributor

@dmytropolityka dmytropolityka commented Oct 25, 2024

Motivation and Context

This change is necessary to fix linting issues within the Athena system. By upgrading the dependencies for module_modeling_llm, we restore compatibility with pylint.A dditionally, the fixes address linting errors in module_programming_llm and assessment_module_manager.

Description

  • Upgraded dependencies of module_modeling_llm to be compatible with pylint.
  • Fixed existing linting errors in module_programming_llm and assessment_module_manager to ensure compliance with updated library.

Steps for Testing

  1. Run prospector on the updated module_modeling_llm and verify that no compatibility issues arise with pylint.
  2. Check module_programming_llm and assessment_module_manager for any remaining linting errors and ensure they are resolved.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to access the test servers.


Screenshots

@dmytropolityka dmytropolityka changed the title fix linting General: Fix linting issues Oct 25, 2024
Copy link
Contributor

@EneaGore EneaGore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@FelixTJDietrich FelixTJDietrich changed the title General: Fix linting issues General: Fix linting issues Oct 28, 2024
Copy link
Collaborator

@FelixTJDietrich FelixTJDietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for that.

@maximiliansoelch I will just merge it.

@FelixTJDietrich FelixTJDietrich merged commit 9c49cc8 into develop Oct 28, 2024
14 checks passed
@FelixTJDietrich FelixTJDietrich deleted the fix/linting-programming-llm branch October 28, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants