-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Artemis integration #47
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
added
the
deployment-error
Added by deployment workflows if an error occured
label
Jul 6, 2023
pal03377
added
deploy:athena-test1
Athena Test Server 1
and removed
deployment-error
Added by deployment workflows if an error occured
labels
Jul 6, 2023
github-actions
bot
added
lock:athena-test1
Is currently deployed to Athena Test Server 1
and removed
deploy:athena-test1
Athena Test Server 1
labels
Jul 6, 2023
pal03377
temporarily deployed
to
Athena Test Server 3
July 6, 2023 17:01
— with
GitHub Actions
Inactive
20 tasks
pal03377
removed
the
lock:athena-test1
Is currently deployed to Athena Test Server 1
label
Jul 12, 2023
pal03377
temporarily deployed
to
Athena Test Server 3
August 5, 2023 03:06
— with
GitHub Actions
Inactive
pal03377
temporarily deployed
to
Athena Test Server 3
August 5, 2023 03:12
— with
GitHub Actions
Inactive
pal03377
temporarily deployed
to
Athena Test Server 3
August 5, 2023 03:28
— with
GitHub Actions
Inactive
pal03377
temporarily deployed
to
Athena Test Server 3
August 5, 2023 03:36
— with
GitHub Actions
Inactive
pal03377
temporarily deployed
to
Athena Test Server 3
August 5, 2023 03:40
— with
GitHub Actions
Inactive
pal03377
temporarily deployed
to
Athena Test Server 3
August 5, 2023 03:48
— with
GitHub Actions
Inactive
FelixTJDietrich
approved these changes
Aug 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes make sense to me and work as expected on the Athena testserver.
13 tasks
Co-authored-by: Felix T.J. Dietrich <[email protected]>
pal03377
removed
the
lock:athena-test1
Is currently deployed to Athena Test Server 1
label
Aug 6, 2023
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: ls1intum/Artemis#6861
Motivation and Context
Some changes are needed to integrate Athena into Artemis.
Description
Change a few things to make the integration work (also some general improvements):
AvailableModuleNames
enum because it always causes issues when some modules are unavailable while the assessment module manager is starting. Replaced it with a simple string./logs
endpoint to see Docker logs => easier testing without SSH test server accessX-API-Secret
header toAuthorization
for consistency within Artemis/feedback
endpoint receive multiple feedback objects at once instead of one at a timeTextSubmission.content
toTextSubmission.text
for consistencyTextSubmission.language
field that is important for CoFee (which only works on English submissions)Steps for Testing
Test ls1intum/Artemis#6861 using the instructions there
Screenshots
see ls1intum/Artemis#6861