Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pull Request pagination #463

Draft
wants to merge 11 commits into
base: staging
Choose a base branch
from

Conversation

egekocabas
Copy link
Member

Work in progress

Motivation

Description

Testing Instructions

Prerequisites:

  • GitHub Account without having any additional access-rights (e.g. admin, owner)
  • ...

Flow:

  1. Log in to Helios as a Developer
  2. Navigate to Settings
  3. ...

Screenshots

Checklist

General

Server

  • Code is performant and follows best practices
  • I documented the Java code using JavaDoc style.

Client

  • I documented the TypeScript code using JSDoc style.
  • I added multiple screenshots/screencasts of my UI changes.
  • I translated all newly inserted strings into English and German.

PullRequestPageRequest pageRequest) {
log.debug("Starting pagination process");
log.debug("Input parameters - Filter: {}, Page: {}, Size: {}, Search Term: {}",
pageRequest.getFilterType(), pageRequest.getPage(), pageRequest.getSize(), pageRequest.getSearchTerm());
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 112).

log.debug("Pagination Details - Page Size: {}, Total Pages: {}", pageSize, totalPages);

// Prepare the final list of PRs for the current page
List<PullRequestBaseInfoDto> pageContent = new ArrayList<>();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck> reported by reviewdog 🐶
Distance between variable 'pageContent' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).

pageRequest.setFilterType(filterType != null ? filterType : PullRequestFilterType.ALL);
pageRequest.setSearchTerm(searchTerm);

PageResponse<PullRequestBaseInfoDto> response = pullRequestService.getPaginatedPullRequests(pageRequest);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 109).

Copy link

codacy-production bot commented Mar 1, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 54aa2111 2.59%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (54aa211) Report Missing Report Missing Report Missing
Head commit (573f2a0) 5703 339 5.94%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#463) 193 5 2.59%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link

github-actions bot commented Mar 9, 2025

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

@github-actions github-actions bot added stale and removed stale labels Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant