Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ingestion status callback update #142
base: main
Are you sure you want to change the base?
Ingestion status callback update #142
Changes from 14 commits
7eef6d0
b276050
377a8d3
537375f
a9f6ec1
201b4b4
2a11f63
854adeb
21980f5
9881684
14cfedc
f7eb738
570e3cf
9f144ae
481ce45
4137bed
a0a9edc
d2695bc
4246fe8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarify the type annotation for
callback
parameterThe
callback
parameter is annotated withingestion_status_callback
, which seems to be a function rather than a type. If it's intended to be a type hint for a callable, consider usingCallable
from thetyping
module.For example:
Alternatively, if
ingestion_status_callback
is a custom type, ensure it follows naming conventions (e.g.,IngestionStatusCallback
).Also applies to: 97-98
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handle
None
value for optionaldto
parameterSince
dto
is now optional, ensure that all usages ofself.dto
in the class handle the case whereself.dto
isNone
to prevent potentialAttributeError
s.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure temporary files are cleaned up even on exceptions
If an exception occurs before
cleanup_temporary_file(pdf_path)
is called, the temporary file may remain on the system. To guarantee cleanup regardless of success or failure, consider using afinally
block.Apply this diff to modify the code:
📝 Committable suggestion