Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Autocompletion type does not reset #465

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Bugfix: Autocompletion type does not reset #465

wants to merge 3 commits into from
+51 −33

Conversation

FelberMartin
Copy link
Collaborator

Problem Description

There was a bug where the requested AutoCompletionType did not reset after removing the tagging character.

This PR fixes #451

Changes

  • When there are not AutoCompletionHints shown, also reset the requested type
  • Refactoring
  • Introduce OnTrueLaunchedEffect

Steps for testing

  1. Go to any chat
  2. Click on the mention button in the ReplyTextField
  3. Click on "Lectures" in the popup
  4. See that only lectures are shown
  5. Remove the inserted "#" character via backspace
  6. Type "#" again
  7. See that all AutoCompletionTypes are shown

@FelberMartin FelberMartin requested a review from julian-wls March 8, 2025 10:46
@FelberMartin FelberMartin self-assigned this Mar 8, 2025
@FelberMartin FelberMartin requested a review from eylulnc March 8, 2025 10:46
@FelberMartin FelberMartin added the ready for review This PR can be reviewed label Mar 8, 2025
@FelberMartin FelberMartin changed the title Bugfix/communication/autocompletion type does not reset Bugfix: Autocompletion type does not reset Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julian-wls julian-wls Awaiting requested review from julian-wls

@eylulnc eylulnc Awaiting requested review from eylulnc

Assignees

@FelberMartin FelberMartin

Labels
ready for review This PR can be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AutoCompletion type does not reset after closing popup
1 participant
@FelberMartin