Skip to content

General: Adjust sorting icon tooltip #1784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Kiara65 wants to merge 15 commits into
base: main
Choose a base branch
from
Open

General: Adjust sorting icon tooltip #1784

Kiara65 wants to merge 15 commits into from

Conversation

@Kiara65
Copy link
Contributor

@Kiara65 Kiara65 commented Jan 23, 2026 •
edited by Abi107717
Loading

Checklist

General

Client

  • I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

The sorting icon tooltip appeared at the right instead of at the top and displayed the text in a cramped, single-character-per-line layout.

Description

  • Added tooltipOptions to the button component
  • Added optional override to the primeng-override file
  • Applied override to the sorting icon

Steps for Testing

Prerequisites:

  1. Go to the landing page
  2. Check that the tooltip switches to the left if there is not enough space at the top and otherwise stays at the top

Review Progress

Code Review

  • Code Review 1

Manual Tests

  • Test 1

Screenshots

Before:
Screenshot 2026-01-23 at 14 26 53
Fix:
Screenshot 2026-01-23 at 14 27 47

@Kiara65 Kiara65 linked an issue Jan 23, 2026 that may be closed by this pull request
Misaligned tooltip for sorting options #1775
Open
@Kiara65 Kiara65 self-assigned this Jan 23, 2026
@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Jan 23, 2026
@Kiara65 Kiara65 marked this pull request as ready for review January 23, 2026 13:58
@Kiara65 Kiara65 requested a review from az108 as a code owner January 23, 2026 13:58
Abi107717
Abi107717 requested changes Jan 23, 2026
View reviewed changes
Copy link
Contributor

@Abi107717 Abi107717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adjusting 😊
Just one small comment

Abi107717
Abi107717 requested changes Jan 23, 2026
View reviewed changes
Copy link
Contributor

@Abi107717 Abi107717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to add the comment 😅

@Bofan-Zhu
Copy link
Contributor

Bofan-Zhu commented Jan 24, 2026

Just one question: I can't reproduce the same problem, for me it already switches to the left if there's not enough space. Could you tell me how to you arrived at this problem?

sachmii and others added 10 commits January 24, 2026 19:53
@sachmii @github-actions @Kiara65
General: Fix school names filter for CIT (#1739)
6ffa2cc 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@Abi107717 @Kiara65
General: Move back button to header on assessment page (#1774)
a1f5804
@renovate @Kiara65
General: Update org.junit.jupiter:junit-jupiter to 6.0.2 (#1792)
3030aa0 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @Kiara65
General: Update tech.jhipster:jhipster-framework to 8.12.0 (#1794)
f969349 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@Abi107717 @az108 @Kiara65
General: Improve date slot card UI (#1788)
e79b1ee 
Co-authored-by: Aniruddh Zaveri <[email protected]>
@Abi107717 @github-actions @Kiara65
Development: Send professor confirmation email on manual slot assig…
f16f039 
…nment (#1779)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@renovate @Kiara65
General: Update checkstyle to 13.0.0 (#1798)
bb54f42 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @Kiara65
General: Update @types/node to 24.10.6 (#1797)
289b843 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@az108 @github-actions @Kiara65
Development: Improve usability for ai generation (#1791)
6590b0c 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@renovate @Kiara65
General: Update @types/node to 24.10.7 (#1800)
c95b18b 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@github-actions github-actions bot added server Pull requests that update Java code. (Added Automatically!) tests user management Code changes in user management module. config-change labels Jan 24, 2026
@Kiara65 Kiara65 requested a review from Abi107717 January 24, 2026 19:02
@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2026

🤖 No OpenAPI or client changes needed.

@Kiara65
Copy link
Contributor Author

Kiara65 commented Jan 24, 2026

Just one question: I can't reproduce the same problem, for me it already switches to the left if there's not enough space. Could you tell me how to you arrived at this problem?

For me, this appears for example on the job overview page when not logged in. In Chrome, it only appears in the German version. In Firefox, it appears for all translations. I’m using a 13-inch display.

@github-actions github-actions bot removed server Pull requests that update Java code. (Added Automatically!) tests user management Code changes in user management module. config-change labels Jan 24, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2026

🤖 No OpenAPI or client changes needed.

Abi107717
Abi107717 approved these changes Jan 24, 2026
View reviewed changes
Copy link
Contributor

@Abi107717 Abi107717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Cathy0123456789
Cathy0123456789 reviewed Jan 24, 2026
View reviewed changes
Copy link
Contributor

@Cathy0123456789 Cathy0123456789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS, looks good, the tooltips are not cramped anymore to the right, thank you! A small question though, in one instance this happens:

Image

Is this meant to be?

Bofan-Zhu
Bofan-Zhu reviewed Jan 24, 2026
View reviewed changes
Copy link
Contributor

@Bofan-Zhu Bofan-Zhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for replying, just one question regarding the tooltip position

@Kiara65
Copy link
Contributor Author

Kiara65 commented Jan 26, 2026

Tested on TS, looks good, the tooltips are not cramped anymore to the right, thank you! A small question though, in one instance this happens:

Image Is this meant to be?

Yes, this is the behaviour from the primeng tooltip. However, it can also be adjusted in the future, maybe with a customized tooltip component, as the one from primeng is a little bit weird sometimes 😅

@Kiara65 Kiara65 added ready for merge PR is ready to merge and removed ready for review labels Jan 26, 2026
CelineLahnor
CelineLahnor approved these changes Jan 26, 2026
View reviewed changes
Copy link
Contributor

@CelineLahnor CelineLahnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you

Cathy0123456789
Cathy0123456789 approved these changes Jan 26, 2026
View reviewed changes
Copy link
Contributor

@Cathy0123456789 Cathy0123456789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the explanation, looks good from my side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Cathy0123456789 Cathy0123456789 Cathy0123456789 approved these changes

@Bofan-Zhu Bofan-Zhu Bofan-Zhu approved these changes

@CelineLahnor CelineLahnor CelineLahnor approved these changes

@Abi107717 Abi107717 Abi107717 approved these changes

@az108 az108 Awaiting requested review from az108 az108 is a code owner

Assignees

@Kiara65 Kiara65

Labels

client Pull requests that update TypeScript code. (Added Automatically!) ready for merge PR is ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Misaligned tooltip for sorting options

8 participants

@Kiara65 @Bofan-Zhu @Cathy0123456789 @CelineLahnor @Abi107717 @sachmii @az108