Skip to content

Conversation

@sachmii
Copy link
Contributor

@sachmii sachmii commented Jan 23, 2026

Checklist

General

Server

  • Important: I implemented the changes with a very good performance and prevented too many (unnecessary) and too complex database calls.
  • I strictly followed the principle of data economy for all database calls.
  • I strictly followed the server coding and design guidelines.
  • I documented the Java code using JavaDoc style.

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
  • I strictly followed the principle of data economy for all client-server REST calls.
  • I strictly followed the client coding and design guidelines.
  • I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
  • I documented the TypeScript code using JSDoc style.
  • I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

Description

Steps for Testing

Prerequisites:

  1. Log in to TumApply

Review Progress

Code Review

  • Code Review 1

Manual Tests

  • Test 1

Test Coverage

Warning: Both client and server tests failed. Coverage could not be fully measured. Please check the workflow logs.

Last updated: 2026-01-23 17:22:52 UTC

Screenshots

sachmii and others added 30 commits January 14, 2026 18:13
…r retention service/job with endpoint to get inactive users
@sachmii sachmii self-assigned this Jan 23, 2026
@sachmii sachmii linked an issue Jan 23, 2026 that may be closed by this pull request
@github-actions github-actions bot added server Pull requests that update Java code. (Added Automatically!) tests database user management Code changes in user management module. job Code changes in job module. evaluation Code changes in evaluation module. config-change labels Jan 23, 2026
@github-actions
Copy link
Contributor

📊 Client Test Coverage Too Low

🔍 View coverage locally:

npm run test:ci
open build/test-results/lcov-report/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-client" artifact from this workflow run.

@github-actions
Copy link
Contributor

@sachmii Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Jan 23, 2026
@github-actions
Copy link
Contributor

🤖 OpenAPI spec and client code auto-updated and committed.

@github-actions
Copy link
Contributor

@sachmii Test coverage has been automatically updated in the PR description.

@github-actions
Copy link
Contributor

📊 Client Test Coverage Too Low

🔍 View coverage locally:

npm run test:ci
open build/test-results/lcov-report/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-client" artifact from this workflow run.

@github-actions
Copy link
Contributor

🤖 No OpenAPI or client changes needed.

@github-actions
Copy link
Contributor

📊 Server Test Coverage Too Low

🔍 View coverage locally:

./gradlew test jacocoTestReport
open build/reports/jacoco/test/html/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-server" artifact from this workflow run.

@github-actions
Copy link
Contributor

@sachmii Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client Pull requests that update TypeScript code. (Added Automatically!) config-change database evaluation Code changes in evaluation module. job Code changes in job module. server Pull requests that update Java code. (Added Automatically!) tests user management Code changes in user management module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warning email before user data deletion

2 participants