`Development`: Improve interview slots management for professors #1789

Abi107717 · 2026-01-23T19:18:04Z

Checklist

General

I tested all changes and their related features with all corresponding user types.
Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
I chose a title conforming to the naming conventions for pull requests.

Server

Important: I implemented the changes with a very good performance and prevented too many (unnecessary) and too complex database calls.
I strictly followed the principle of data economy for all database calls.
I strictly followed the server coding and design guidelines.
I documented the Java code using JavaDoc style.

Client

Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
I strictly followed the principle of data economy for all client-server REST calls.
I strictly followed the client coding and design guidelines.
I documented the TypeScript code using JSDoc style.
I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

Currently, it is possible to send invitations to more applicants than there are available interview slots, which leads to booking issues.

Description

This PR improves the invitation flow by adding a warning dialog if the number of available future slots is insufficient for the selected applicants. It integrates the empty slot state directly into the calendar view for a cleaner UI and refactors the slot creation trigger to use Angular Signals. Past slots are now visually distinguished (greyed out), and the "Add Slots" button visibility is optimized.

Steps for Testing

Prerequisites:

Log in to TumApply as professor
Navigate to an Interview Process with some uncontacted applicants. (interviews/overview)

Scenario 1: Insufficient Slots Warning

Ensure the number of uncontacted applicants is greater than the available future slots.
Click "Send Invitations" in the Interviewee Section.
Verify that a warning dialog appears stating "Not enough slots available".
Click "Add Slots" and verify the slot creation modal opens.

Scenario 2: Empty State & adding Slots

Ensure the process has no future slots.
Verify the calendar view shows the "Currently no slots available" message with an "Add Slots" button.
Verify the top-right "Add Slots" button in the month navigation is hidden.
Add a new slot.
Verify the empty state disappears and the newly added slot is visible.

Scenario 3: Past Slots

Navigate to a month with past execution slots.
Verify that past slots appear with reduced opacity (greyed out).

Review Progress

Code Review

Code Review 1

Manual Tests

Test 1

Test Coverage

Warning: Both client and server tests failed. Coverage could not be fully measured. Please check the workflow logs.

Last updated: 2026-01-27 13:10:57 UTC

Screenshots

Scenario 1

Scenario2

Scenario 3

** If it's a completely new interview process and there are no slots at all**

github-actions · 2026-01-23T19:19:11Z

@Abi107717 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

github-actions · 2026-01-23T19:21:27Z

@Abi107717 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

github-actions · 2026-01-23T19:22:10Z

🤖 OpenAPI spec and client code auto-updated and committed.

github-actions · 2026-01-23T19:24:02Z

@Abi107717 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

github-actions · 2026-01-23T19:24:39Z

🤖 No OpenAPI or client changes needed.

- Apply disabled styles (greyed out) for past slots in UI - Hide edit/delete/assign actions for past slots

github-actions · 2026-01-23T21:27:34Z

@Abi107717 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

github-actions · 2026-01-23T21:28:01Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-01-23T21:35:30Z

@Abi107717 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

github-actions · 2026-01-23T21:36:13Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-01-23T21:55:55Z

@Abi107717 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

github-actions · 2026-01-23T21:56:16Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-01-23T22:01:18Z

@Abi107717 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

github-actions · 2026-01-23T22:02:07Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-01-23T22:05:46Z

@Abi107717 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

github-actions · 2026-01-24T19:52:41Z

@Abi107717 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

github-actions · 2026-01-24T19:54:03Z

🤖 No OpenAPI or client changes needed.

Bofan-Zhu

Thank you for improving this 😊. I left some comments.
Functionality looks good to me

src/main/webapp/i18n/de/interview.json

...ain/webapp/app/interview/interview-process-detail/slots-section/slots-section.component.html

...bapp/app/interview/interview-process-detail/slots-section/slot-card/slot-card.component.html

Bofan-Zhu · 2026-01-26T16:21:24Z

src/main/java/de/tum/cit/aet/interview/repository/InterviewSlotRepository.java

+        """
+        SELECT COUNT(s) FROM InterviewSlot s
+        WHERE s.interviewProcess.id = :processId
+        AND s.startDateTime > :now


I think hibernate provides CURRENT_TIMESTAMP or something similar if I'm not mistaken

github-actions · 2026-01-27T13:10:59Z

@Abi107717 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

github-actions · 2026-01-27T13:15:33Z

🤖 No OpenAPI or client changes needed.

Abi107717 added 2 commits January 23, 2026 20:13

add query and method

8708df8

Add endpoint

eaa4805

Abi107717 self-assigned this Jan 23, 2026

Abi107717 linked an issue Jan 23, 2026 that may be closed by this pull request

Improve Professor Slot Visibility + Prevent Sending Invitations Without Enough Slots #1767

Open

github-actions bot added the server Pull requests that update Java code. (Added Automatically!) label Jan 23, 2026

add removed query

999c346

chore: update OpenAPI spec and generated client

fcdb6d1

github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Jan 23, 2026

Abi107717 added 2 commits January 23, 2026 20:41

- Compute isPast state for interview slots based on start time

f4b97ce

- Apply disabled styles (greyed out) for past slots in UI - Hide edit/delete/assign actions for past slots

feat(interview): enhance slot management and invitation flow

27b4d8a

fix codacy

0a02eb4

helios-aet bot temporarily deployed to test-server January 23, 2026 21:46 Inactive

add capacity check when sending single invitation

e112715

add capacity check when sending single invitation

5fe5053

Abi107717 marked this pull request as ready for review January 23, 2026 22:04

Abi107717 requested a review from az108 as a code owner January 23, 2026 22:04

github-actions bot added the ready for review label Jan 23, 2026

Merge branch 'main' into feature/slots-empty-state-and-invite-guard

77ec3e9

Bofan-Zhu requested changes Jan 26, 2026

View reviewed changes

Abi107717 added 2 commits January 26, 2026 20:23

adjust keys

43a0038

adjust styling

e0df13f

Abi107717 marked this pull request as draft January 27, 2026 16:27

Abi107717 removed the ready for review label Jan 29, 2026

Development: Improve interview slots management for professors #1789

Are you sure you want to change the base?

Development: Improve interview slots management for professors #1789

Uh oh!

Conversation

Abi107717 commented Jan 23, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

General

Server

Client

Motivation and Context

Description

Steps for Testing

Review Progress

Code Review

Manual Tests

Test Coverage

Screenshots

Uh oh!

github-actions bot commented Jan 23, 2026

Uh oh!

github-actions bot commented Jan 23, 2026

Uh oh!

github-actions bot commented Jan 23, 2026

Uh oh!

github-actions bot commented Jan 23, 2026

Uh oh!

github-actions bot commented Jan 23, 2026

Uh oh!

github-actions bot commented Jan 23, 2026

Uh oh!

github-actions bot commented Jan 23, 2026

Uh oh!

github-actions bot commented Jan 23, 2026

Uh oh!

github-actions bot commented Jan 23, 2026

Uh oh!

github-actions bot commented Jan 23, 2026

Uh oh!

github-actions bot commented Jan 23, 2026

Uh oh!

github-actions bot commented Jan 23, 2026

Uh oh!

github-actions bot commented Jan 23, 2026

Uh oh!

github-actions bot commented Jan 23, 2026

Uh oh!

github-actions bot commented Jan 24, 2026

Uh oh!

github-actions bot commented Jan 24, 2026

Uh oh!

Bofan-Zhu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Bofan-Zhu Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 27, 2026

Uh oh!

github-actions bot commented Jan 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

`Development`: Improve interview slots management for professors #1789

`Development`: Improve interview slots management for professors #1789

Abi107717 commented Jan 23, 2026 •

edited by github-actions bot

Loading