Skip to content

Conversation

@Abi107717
Copy link
Contributor

@Abi107717 Abi107717 commented Jan 24, 2026

Checklist

General

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
  • I strictly followed the principle of data economy for all client-server REST calls.
  • I strictly followed the client coding and design guidelines.
  • I documented the TypeScript code using JSDoc style.
  • I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

The interview process detail page suffered from layout overlapping issues when resizing the window, particularly with slot cards and filter tabs. The goal was to implement a fluid layout that adapts gracefully to different screen widths to prevent content from merging or breaking.

Description

Implemented a responsive grid for the slots section that dynamically adjusts column counts and updated the filter tabs to wrap properly instead of scrolling.

❗️Note: Full mobile responsiveness is not yet perfect and will be addressed in a future update; the primary focus here was to ensure stability during window resizing.❗️

Steps for Testing

Prerequisites:

  1. Log in to TumApply as professor
  2. go to /interviews/overview
  3. Choose a process
  4. Resize window and verify, responsiveness is acceptable

Review Progress

Code Review

  • Code Review 1

Manual Tests

  • Test 1

Test Coverage

Warning: Client tests failed. Coverage could not be fully measured. Please check the workflow logs.

Last updated: 2026-01-28 16:25:09 UTC

Screenshots

image image

@Abi107717 Abi107717 self-assigned this Jan 24, 2026
@Abi107717 Abi107717 linked an issue Jan 24, 2026 that may be closed by this pull request
9 tasks
@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Jan 24, 2026
@github-actions
Copy link
Contributor

@Abi107717 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@github-actions
Copy link
Contributor

@Abi107717 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@Abi107717 Abi107717 marked this pull request as ready for review January 24, 2026 20:06
@Abi107717 Abi107717 requested a review from az108 as a code owner January 24, 2026 20:06
@github-actions
Copy link
Contributor

@Abi107717 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@Bofan-Zhu
Copy link
Contributor

Will responsiveness for interviews/overview page also be addressed in future PRs?
image
On small screens the current process card needs to be structured in another way

Copy link
Contributor

@Bofan-Zhu Bofan-Zhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improving the responsiveness of the interview pages. It already looks a lot better!

image If you open the slot creation modal and reduce your screen height, some components e.g. save button are not visible anymore and the user also cannot scroll down. Maybe we could fix that as well

@github-actions
Copy link
Contributor

@Abi107717 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@Abi107717 Abi107717 requested a review from Bofan-Zhu January 27, 2026 12:21
@Abi107717 Abi107717 added the ready for merge PR is ready to merge label Jan 27, 2026
Copy link
Contributor

@Cathy0123456789 Cathy0123456789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing, I tested it locally, it doesn't overlap anymore now :)
I see two scrollbars now though, maybe that could be changed?

Image

@github-actions
Copy link
Contributor

@Abi107717 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

Copy link
Contributor

@sachmii sachmii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works just fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client Pull requests that update TypeScript code. (Added Automatically!) ready for merge PR is ready to merge ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Interview Process Detail Page responsiveness

5 participants