-
Notifications
You must be signed in to change notification settings - Fork 0
General: Relocate back buttons for deep navigation pages
#1803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
General: Relocate back buttons for deep navigation pages
#1803
Conversation
|
📊 Client Test Coverage Too Low 🔍 View coverage locally: npm run test:ci
open build/test-results/lcov-report/index.html🌐 View coverage from GitHub: |
…e-content-container
ge94zec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for implementing! I tested it on test server :)
Cathy0123456789
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS, works great thank you! Does it make sense to add this as well for the Research Group Detail page for admins since the Save button is at the top too?
Cathy0123456789
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, admin page will be adjusted sometime later on
Abi107717
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, tested locally LGTM
Checklist
General
Motivation and Context
All buttons are currently placed on the bottom left. This should only be the case for navigating e.g. within forms but not for deep navigation.
Description
This PR:
Steps for Testing
Prerequisites:
Review Progress
Code Review
Manual Tests
Screenshots