Skip to content

Conversation

@Bofan-Zhu
Copy link
Contributor

Checklist

General

Motivation and Context

All buttons are currently placed on the bottom left. This should only be the case for navigating e.g. within forms but not for deep navigation.

Description

This PR:

  • adds a reusable back button component
  • replaces the back buttons on deep navigation pages with the reusable back button component
  • moves saving state of email template to the top to increase visibility

Steps for Testing

Prerequisites:

  1. Log in to TumApply as Professor/Applicant
  2. Check that buttons on the pages which cannot be accessed via sidebar are located at the top left

Review Progress

Code Review

  • Code Review 1

Manual Tests

  • Test 1

Screenshots

image image image

@Bofan-Zhu Bofan-Zhu self-assigned this Jan 24, 2026
@Bofan-Zhu Bofan-Zhu requested a review from az108 as a code owner January 24, 2026 22:51
@Bofan-Zhu Bofan-Zhu linked an issue Jan 24, 2026 that may be closed by this pull request
@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Jan 24, 2026
@Bofan-Zhu Bofan-Zhu added the shared Code changes in shared modules label Jan 24, 2026
@github-actions
Copy link
Contributor

📊 Client Test Coverage Too Low

🔍 View coverage locally:

npm run test:ci
open build/test-results/lcov-report/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-client" artifact from this workflow run.

Copy link
Contributor

@ge94zec ge94zec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for implementing! I tested it on test server :)

Copy link
Contributor

@Cathy0123456789 Cathy0123456789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS, works great thank you! Does it make sense to add this as well for the Research Group Detail page for admins since the Save button is at the top too?

Copy link
Contributor

@Cathy0123456789 Cathy0123456789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, admin page will be adjusted sometime later on

@Bofan-Zhu Bofan-Zhu added ready for merge PR is ready to merge and removed ready for review labels Jan 27, 2026
Copy link
Contributor

@Abi107717 Abi107717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, tested locally LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client Pull requests that update TypeScript code. (Added Automatically!) ready for merge PR is ready to merge shared Code changes in shared modules tests ui/ux improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move back buttons to the top left of the content container

5 participants