Skip to content

Conversation

@Abi107717
Copy link
Contributor

@Abi107717 Abi107717 commented Jan 28, 2026

Checklist

General

Server

  • Important: I implemented the changes with a very good performance and prevented too many (unnecessary) and too complex database calls.
  • I strictly followed the principle of data economy for all database calls.
  • I strictly followed the server coding and design guidelines.
  • I documented the Java code using JavaDoc style.

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
  • I strictly followed the principle of data economy for all client-server REST calls.
  • I strictly followed the client coding and design guidelines.
  • I documented the TypeScript code using JSDoc style.
  • I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

Professors needed a way to quickly see their next scheduled interviews across all job positions without navigating into each individual interview process.

Description

Implemented an "Upcoming Interviews" widget on the Interview Overview page that displays a chronological list of future booked interview slots. The layout was made responsive, and the navigation was improved so that returning from an assessment takes the user back to the overview if they came from there.

Steps for Testing

Prerequisites:

  1. Log in to TumApply as a professor
  2. Go to /interviews-overview/
  3. Verify the Overview Page is responsive also check mobile responsiveness
  4. Choose a process, add an interviewee if needed, assign that interviewee to a future slot
  5. Go back to interviews Overview page and verify an upcoming interview card appeared
  6. Click on that Card, verify you are on the assessment page
  7. Click on the back button and verify you are on the overview page again and not the process detail page

Review Progress

Code Review

  • Code Review 1

Manual Tests

  • Test 1

Test Coverage

Warning: Both client and server tests failed. Coverage could not be fully measured. Please check the workflow logs.

Last updated: 2026-01-29 04:53:41 UTC

Screenshots

No upcoming Interview
image

Upcoming Interviews
image

Responsiveness
image

image

@Abi107717 Abi107717 linked an issue Jan 28, 2026 that may be closed by this pull request
@Abi107717 Abi107717 self-assigned this Jan 28, 2026
@github-actions github-actions bot added the server Pull requests that update Java code. (Added Automatically!) label Jan 28, 2026
@github-actions
Copy link
Contributor

@Abi107717 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@github-actions
Copy link
Contributor

📊 Server Test Coverage Too Low

🔍 View coverage locally:

./gradlew test jacocoTestReport
open build/reports/jacoco/test/html/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-server" artifact from this workflow run.

@github-actions
Copy link
Contributor

@Abi107717 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@github-actions
Copy link
Contributor

🤖 OpenAPI spec and client code auto-updated and committed.

@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Jan 28, 2026
@github-actions
Copy link
Contributor

@Abi107717 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@github-actions
Copy link
Contributor

🤖 No OpenAPI or client changes needed.

@github-actions
Copy link
Contributor

📊 Server Test Coverage Too Low

🔍 View coverage locally:

./gradlew test jacocoTestReport
open build/reports/jacoco/test/html/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-server" artifact from this workflow run.

@github-actions
Copy link
Contributor

@Abi107717 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@github-actions
Copy link
Contributor

🤖 No OpenAPI or client changes needed.

@github-actions
Copy link
Contributor

📊 Server Test Coverage Too Low

🔍 View coverage locally:

./gradlew test jacocoTestReport
open build/reports/jacoco/test/html/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-server" artifact from this workflow run.

@github-actions
Copy link
Contributor

@Abi107717 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@github-actions
Copy link
Contributor

🤖 No OpenAPI or client changes needed.

@github-actions
Copy link
Contributor

📊 Server Test Coverage Too Low

🔍 View coverage locally:

./gradlew test jacocoTestReport
open build/reports/jacoco/test/html/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-server" artifact from this workflow run.

@Abi107717 Abi107717 marked this pull request as ready for review January 28, 2026 13:14
@Abi107717 Abi107717 requested a review from az108 as a code owner January 28, 2026 13:14
@github-actions
Copy link
Contributor

🤖 No OpenAPI or client changes needed.

@github-actions
Copy link
Contributor

@Abi107717 Test coverage has been automatically updated in the PR description.

@github-actions
Copy link
Contributor

@Abi107717 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

Copy link
Contributor

@sachmii sachmii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for implementing! Just few remarks

Comment on lines 60 to 61
<i class="pi pi-exclamation-triangle text-negative text-2xl mb-2"></i>
<p class="text-text-secondary text-sm" jhiTranslate="interview.overview.error.failedToLoad"></p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to maybe use the existing info-box component?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would look like this:
image

Comment on lines 77 to 78
<i class="pi pi-calendar text-text-tertiary text-2xl mb-3"></i>
<p class="text-sm text-text-secondary" jhiTranslate="interview.overview.upcoming.empty"></p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here as well maybe?

@github-actions
Copy link
Contributor

🤖 No OpenAPI or client changes needed.

@github-actions
Copy link
Contributor

@Abi107717 Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client Pull requests that update TypeScript code. (Added Automatically!) ready for review server Pull requests that update Java code. (Added Automatically!)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display "Upcoming Interviews" on Interview Overview Page

3 participants