Skip to content

Conversation

@Bofan-Zhu
Copy link
Contributor

@Bofan-Zhu Bofan-Zhu commented Jan 28, 2026

Checklist

General

Server

  • Important: I implemented the changes with a very good performance and prevented too many (unnecessary) and too complex database calls.
  • I strictly followed the principle of data economy for all database calls.
  • I strictly followed the server coding and design guidelines.
  • I documented the Java code using JavaDoc style.

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
  • I strictly followed the principle of data economy for all client-server REST calls.
  • I strictly followed the client coding and design guidelines.
  • I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
  • I documented the TypeScript code using JSDoc style.
  • I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

Description

Steps for Testing

Prerequisites:

  1. Log in to TumApply

Review Progress

Code Review

  • Code Review 1

Manual Tests

  • Test 1

Test Coverage

Warning: Client tests failed. Coverage could not be fully measured. Please check the workflow logs.

Last updated: 2026-01-28 22:18:43 UTC

Screenshots

@Bofan-Zhu Bofan-Zhu self-assigned this Jan 28, 2026
@Bofan-Zhu Bofan-Zhu linked an issue Jan 28, 2026 that may be closed by this pull request
2 tasks
@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Jan 28, 2026
@github-actions
Copy link
Contributor

@Bofan-Zhu Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client Pull requests that update TypeScript code. (Added Automatically!)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Hero Image to Improve Text Legibility and Subject Composition

2 participants