Skip to content

Conversation

@stackmystack
Copy link
Contributor

@stackmystack stackmystack commented Jul 29, 2024

Description

Fixes #1521.

Avoid errors like:

  `first': cannot get the first element of beginless range

Completed Tasks

  • I have read the [Contributing Guide][contrib].
  • The pull request is complete (implemented / written).
  • Git commits have been cleaned up (squash WIP / revert commits).
  • I wrote tests and ran bundle exec rake locally (if code is attached to PR).
    • for ast_node.rb
    • for ruby_parser.rb : this one is a bit more involved (and may be unnecessary since it touches on the whole test suite), and I don't think I want to commit to writing tests for it if PR altogether is rejected for any reason.

@stackmystack stackmystack force-pushed the fix-range-access branch 3 times, most recently from 51864d3 to c3b9b72 Compare September 12, 2024 12:26
@stackmystack
Copy link
Contributor Author

Hello, Could you please allow the tests to run again?
I fixed them on my branch, and it should work everywhere else.

PS:

In the CI run, runners on macOS+amd64 and ruby < 2.6 do not work. You should remove them I guess?

@lsegal lsegal merged commit b55ad78 into lsegal:main May 9, 2025
15 checks passed
@lsegal
Copy link
Owner

lsegal commented May 9, 2025

Thanks for the work on this, sorry it took so long to get in!

@romanbsd
Copy link

Can you release a new version please? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RangeError When using pattern matching in YARD documentation generation

3 participants