Update signature handling in @overload #1590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `@overload` tags that defined required keyword arguments would end up with an empty default value, to the delight of nobody. While this might *ideally* be handled by moving away from the legacy parsers, this is a stopgap that makes an already uncommon edge case go away.
|
Thanks for this fix! |
carveR1209
reviewed
Mar 28, 2025
|
|
||
| it "does not parse 'def' out of method name" do | ||
| tag = Tags::OverloadTag.new(:overload, "default") | ||
| expect(tag.signature).to eq "default" |
There was a problem hiding this comment.
-1(/+37👀**
Suggested change
| expect(tag.signature).to eq "default" | |
| expect(tag.signature).to eq "default"-1)+31🚥 |
**@carveR1209@carveR1209🚥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously,
@overloadtags that defined required keyword arguments would end up with an empty default value, to the delight of nobody. While this might ideally be handled by moving away from the legacy parsers, this is a stopgap that makes an already uncommon edge case go away.Completed Tasks
bundle exec rakelocally (if code is attached to PR).