Only load from cgi what is required for Ruby 3.5
#1616
Merged
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Ruby 3.5 most of the cgi gem will be removed. Only the various escape/unescape methods will be retained by default. But: * On Ruby 3.5, `cgi/escape` is enough * Earlier versions need `cgi/util` since the unescape methods don't work otherwise. I tested this down to Ruby 2.0. https://bugs.ruby-lang.org/issues/21258
|
Awesome fix, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Ruby 3.5 most of the cgi gem will be removed. Only the various escape/unescape methods will be retained by default.
But:
cgi/escapeis enoughcgi/utilsince the unescape methods don't work otherwise.I tested this down to Ruby 2.0.
https://bugs.ruby-lang.org/issues/21258
Completed Tasks
bundle exec rakelocally (if code is attached to PR).