DM-47529: Migrate Prompt Processing PipelinesConfig to YAML #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
force-pushed
the
tickets/DM-47529
branch
from
8e019f6
to
c1655d9
Compare
erinleighh
approved these changes
Nov 18, 2024
A typical run has two simultaneous instances (one for preprocessing, one for the main pipeline), so this disclaimer is redundant.
Delegating parsing to YAML makes it much easier to add more fields to the pipelines spec, and even this basic implementation catches some escaping errors in the original tests.
Making the activator responsible for YAML input leads to better seperation of concerns. It also makes unit tests slightly better-behaved, because they can be expressed in pure Python. However, this change makes some test cases obsolete, because they specifically test text formatting.
kfindeisen
force-pushed
the
tickets/DM-47529
branch
from
b42abaa
to
82a4ba6
Compare
Previously, pipeline configs behaved as a mapping from survey to pipeline list; this design didn't support more complex specs (wildcards, spatial constraints, etc.). Taking the first block that "matches" a visit allows for more free-form specification of when pipelines should be run.
This change allows for cleaner separation of concerns, as all input handling is now done by _Spec.
No longer requiring a survey makes it possible to naturally add in other optional constraints, such as position.
kfindeisen
force-pushed
the
tickets/DM-47529
branch
from
82a4ba6
to
c8ec90d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the bespoke pipelines config format with an extensible YAML-based format, and modifies the config semantics to behave like a prioritized list instead of a mapping. These changes will make it much easier to add new kinds of constraints to the format in the future.