DM-47591: Allow main pipeline execution if preprocessing pipeline fails#223
Merged
kfindeisen merged 2 commits intomainfrom Nov 19, 2024
Merged
DM-47591: Allow main pipeline execution if preprocessing pipeline fails#223kfindeisen merged 2 commits intomainfrom
kfindeisen merged 2 commits intomainfrom
Conversation
These exceptions let us distinguish failures in loading or managing pipelines from failures in task execution.
kfindeisen
force-pushed
the
tickets/DM-47591
branch
from
e9415b8 to
f66f7e5
Compare
andy-slac
approved these changes
Nov 19, 2024
Contributor
andy-slac
left a comment
andy-slac
left a comment
There was a problem hiding this comment.
Looks good, one minor question. Devising a good exception hierarchy is hard, if anything needs to be improved in that regard in daf_butler or ctrl_mpexec, let us know.
It may be possible to run main pipelines even if preprocessing fails or cannot be attempted; defer that decision to quantum graph generation.
kfindeisen
force-pushed
the
tickets/DM-47591
branch
from
f66f7e5 to
b8a61bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the error handling around pipeline execution, distinguishing PP execution failures from pipeline failures and ignoring the latter for preprocessing pipelines.