Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-47591: Allow main pipeline execution if preprocessing pipeline fails #223

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

kfindeisen
Copy link
Member

This PR improves the error handling around pipeline execution, distinguishing PP execution failures from pipeline failures and ignoring the latter for preprocessing pipelines.

These exceptions let us distinguish failures in loading or managing
pipelines from failures in task execution.
Copy link
Contributor

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one minor question. Devising a good exception hierarchy is hard, if anything needs to be improved in that regard in daf_butler or ctrl_mpexec, let us know.

python/activator/exception.py Show resolved Hide resolved
It may be possible to run main pipelines even if preprocessing fails or
cannot be attempted; defer that decision to quantum graph generation.
@kfindeisen kfindeisen merged commit 7ace24a into main Nov 19, 2024
5 checks passed
@kfindeisen kfindeisen deleted the tickets/DM-47591 branch November 19, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants