Skip to content

Tickets/DM-51761: Add closed_loop task timeout and fault system with large defocus #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 11, 2025

Conversation

gmegh
Copy link
Contributor

@gmegh gmegh commented Jul 10, 2025

No description provided.

Copy link
Member

@tribeiro tribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just see my comment about allowing us to specify None in the configuration for the timeout, which would fall back to "no timeout".

in seconds. If the closed loop task does not
receive images for this amount of time, it will
stop the closed loop.
type: integer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to consider having an option to specify no timeout. I think it would be something like:

    anyOf:
      - type: string
      - type: "null"

@gmegh gmegh force-pushed the tickets/DM-51761 branch from d1a3aaf to aaf2299 Compare July 11, 2025 10:48
@gmegh gmegh merged commit 8b34251 into develop Jul 11, 2025
4 checks passed
@gmegh gmegh deleted the tickets/DM-51761 branch July 11, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants